GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(common): make the `CommonModule` pipes standalone by AndrewKushnir · Pull Request #46401 · angular/angular

Conversation

@AndrewKushnir

@AndrewKushnir AndrewKushnir commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

This commit updates the pipes presents in the CommonModule and annotates them with the standalone: true flag. With that flag, the pipes can now be imported individually, as well as imported via the CommonModule.

PR Type

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
14837-eng reacted with confused emoji tonivj5 and antischematic reacted with heart emoji
All reactions
  • 😕 1 reaction
  • ❤️ 2 reactions
@AndrewKushnir AndrewKushnir added state: WIP area: common Issues related to APIs in the @angular/common package target: minor This PR is targeted for the next minor release cross-cutting: standalone Issues related to the NgModule-less world labels Jun 17, 2022
@ngbot ngbot Bot added this to the Backlog milestone Jun 17, 2022
@AndrewKushnir
AndrewKushnir force-pushed the common_pipes_standalone branch 3 times, most recently from f374037 to 12e8af1 Compare June 23, 2022 02:22
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jun 23, 2022
@AndrewKushnir
AndrewKushnir requested review from alxhub and pkozlowski-opensource June 23, 2022 02:23
@AndrewKushnir
AndrewKushnir marked this pull request as ready for review June 23, 2022 02:23
@pullapprove
pullapprove Bot requested a review from dylhunn June 23, 2022 02:23
@AndrewKushnir
feat(common): make the CommonModule pipes standalone
dc9c472 
This commit updates the pipes presents in the `CommonModule` and annotates them with the `standalone: true` flag. With that flag, the pipes can now be imported individually, as well as imported via the `CommonModule`.
@AndrewKushnir
AndrewKushnir force-pushed the common_pipes_standalone branch from 12e8af1 to dc9c472 Compare June 23, 2022 02:24
@AndrewKushnir

AndrewKushnir commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Exploratory presubmit (TGP).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir AndrewKushnir mentioned this pull request Jun 23, 2022
feat(common): make the CommonModule directives standalone #46469
Closed
2 of 3 tasks
pkozlowski-opensource
pkozlowski-opensource reviewed Jun 23, 2022
View reviewed changes
Comment thread goldens/public-api/common/index.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pullapprove
pullapprove Bot requested a review from jessicajaniuk June 23, 2022 08:11
pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 23, 2022
View reviewed changes

@pkozlowski-opensource pkozlowski-opensource left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
alxhub
alxhub approved these changes Jun 23, 2022
View reviewed changes

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jessicajaniuk
jessicajaniuk approved these changes Jun 23, 2022
View reviewed changes

@jessicajaniuk jessicajaniuk left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api, fw-common

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jessicajaniuk
jessicajaniuk removed the request for review from dylhunn June 23, 2022 17:47
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2022
@dylhunn

dylhunn commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 4a2e733.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dylhunn dylhunn closed this in 4a2e733 Jun 23, 2022
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 24, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments
@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes
@alxhub alxhub alxhub approved these changes
+1 more reviewer
@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cross-cutting: standalone Issues related to the NgModule-less world target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@AndrewKushnir @dylhunn @JoostK @pkozlowski-opensource @alxhub @jessicajaniuk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.