GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(router): allow to return `UrlTree` from `CanMatchFn` by dimakuba · Pull Request #46455 · angular/angular

Conversation

@dimakuba

@dimakuba dimakuba commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Currently it's not possible to return plain UrlTree from CanMatchFn,
only wrapped UrlTree into Observable or Promise is allowed.
These changes allow to return UrlTree from CanMatchFn.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dimakuba
fix(router): allow to return UrlTree from CanMatchFn
f6cdf9b 
Currently it's not possible to return plain `UrlTree` from `CanMatchFn`,
only wrapped `UrlTree` into Observable or Promise is allowed.
These changes allow to return `UrlTree` from `CanMatchFn`.
@pullapprove
pullapprove Bot requested a review from AndrewKushnir June 22, 2022 15:56
@AndrewKushnir
AndrewKushnir requested review from atscott and removed request for AndrewKushnir June 22, 2022 17:31
atscott
atscott approved these changes Jun 22, 2022
View reviewed changes

@atscott atscott left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-router
reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pullapprove
pullapprove Bot requested review from AndrewKushnir, alxhub and jessicajaniuk June 22, 2022 17:31
AndrewKushnir
AndrewKushnir approved these changes Jun 22, 2022
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jessicajaniuk
jessicajaniuk approved these changes Jun 22, 2022
View reviewed changes

@jessicajaniuk jessicajaniuk left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jessicajaniuk
jessicajaniuk removed the request for review from alxhub June 22, 2022 17:37
@jessicajaniuk jessicajaniuk added area: router target: patch This PR is targeted for the next patch release labels Jun 22, 2022
@ngbot ngbot Bot modified the milestone: Backlog Jun 22, 2022
@jessicajaniuk jessicajaniuk added the action: presubmit The PR is in need of a google3 presubmit label Jun 22, 2022
@AndrewKushnir AndrewKushnir added action: global presubmit The PR is in need of a google3 global presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels Jun 22, 2022
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit labels Jun 22, 2022
@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 22, 2022
@AndrewKushnir

AndrewKushnir commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit abe3759.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir AndrewKushnir closed this in abe3759 Jun 22, 2022
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 23, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+1 more reviewer
@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dimakuba @AndrewKushnir @atscott @jessicajaniuk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.