GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(core): remove `@internal` annotation from `ApplicationRef.injector` by arturovt · Pull Request #46727 · angular/angular

Conversation

@arturovt

@arturovt arturovt commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

The injector getter is annotated with @internal and is removed from declarations.
This commit removes the annotation thus it's possible to access the injector on the
ApplicationRef, e.g., after calling bootstrapApplication.

Currently, it requires casting ApplicationRef to { injector: Injector } after calling the bootstrapApplication, e.g.:

bootstrapApplication(...).then((appRef) => {
  const injector = (appRef as unknown as { injector: Injector }).injector;
  const router = injector.get(Router);
  ...
});

NgModuleRef prior to ApplicationRef has a public injector property which allows the above behavior:

platformBrowserDynamic()
  .bootstrapModule(...)
  .then((ngModuleRef) => {
    const router = ngModuleRef.injector.get(Router);
    ...
  });

This change also allows a more straightforward setup for micro-frontend adapters (e.g., single-spa-angular). The micro-frontend bootstrap function can resolve to ApplicationRef | NgModuleRef<T>; they both have the destroy method now, and having injector on both types doesn't require type cast for ApplicationRef.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@arturovt
fix(core): remove @internal annotation from ApplicationRef.injector
6c6465c
The `injector` getter is annotated with `@internal` and is removed from declarations.
This commit removes the annotation thus it's possible to access the `injector` on the
`ApplicationRef`, e.g., after calling `bootstrapApplication`.
@pullapprove
pullapprove Bot requested a review from pkozlowski-opensource July 6, 2022 17:04
@pkozlowski-opensource

pkozlowski-opensource commented Jul 6, 2022

Copy link
Copy Markdown
Member

Thnx, but we are going to go with #46665 instead

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkozlowski-opensource pkozlowski-opensource closed this Jul 6, 2022
@arturovt
arturovt deleted the fix/core-injector-internal branch July 6, 2022 17:17
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Aug 6, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@arturovt @pkozlowski-opensource
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.