GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(zone.js): jest 29 should ignore uncaught error console log by JiaLiPassion · Pull Request #49325 · angular/angular

Conversation

@JiaLiPassion

@JiaLiPassion JiaLiPassion commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Close #49110

In jest 29, should disable uncaught error console.log.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JiaLiPassion JiaLiPassion added area: zones Issues related to zone.js target: minor This PR is targeted for the next minor release labels Mar 6, 2023
@ngbot ngbot Bot added this to the Backlog milestone Mar 6, 2023
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Mar 6, 2023
@JiaLiPassion
JiaLiPassion requested a review from AndrewKushnir March 6, 2023 00:51
AndrewKushnir
AndrewKushnir reviewed Mar 6, 2023
View reviewed changes
Comment thread packages/zone.js/lib/jest/jest.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JiaLiPassion
JiaLiPassion force-pushed the ignore-error-jest branch from 12358cb to 6cd069a Compare March 25, 2023 02:42
@JiaLiPassion
feat(zone.js): jest 29 should ignore uncaught error console log
5c431da 
Close angular#49110

From jest 29 and jest-preset-angular v13, the module transform logic
changed, and now jest-preset-angular use the use the tsconfig target
other than the hardcoded one, thymikee/jest-preset-angular#2010
But jest-angular-preset doesn't introduce the @babel/plugin-transform-async-to-generator
which is needed by angular since `async/await` still need to be transformed
to promise for ES2017+ target.
So for now, we disable to output the uncaught error console log for a temp solution,
until jest-preset-angular find a proper solution.
@JiaLiPassion
JiaLiPassion force-pushed the ignore-error-jest branch from 6cd069a to 5c431da Compare March 25, 2023 02:50
AndrewKushnir
AndrewKushnir approved these changes Mar 27, 2023
View reviewed changes
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Mar 27, 2023
@AndrewKushnir

AndrewKushnir commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Presubmit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 27, 2023
@atscott

atscott commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit bc412fd.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atscott atscott closed this in bc412fd Mar 27, 2023
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Apr 27, 2023

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

While testing with Jest 29, zone.js prints an Unhandled Promise rejection using firstValueFrom

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JiaLiPassion @AndrewKushnir @atscott
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.