GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(core): Discard self-imports on standalone components. by JeanMeche · Pull Request #50557 · angular/angular

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Jun 2, 2023

Copy link
Copy Markdown
Member

Before this fix, a self import would define the component twice in the directiveRegistry which would then fire a NG0300 when compiled with the JIT.

fixes #50525
Note: #50554 also fixes #50525, there were two issues in one.

  • Bugfix

Does this PR introduce a breaking change?

  • No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JeanMeche
fix(core): Discard self-imports on standalone components.
9b1b396 
Before this fix, a self import would define the component twice in the `directiveRegistry` which would then fire a `NG0300` when compiled with the JIT.

fixes angular#50525
@JeanMeche
JeanMeche force-pushed the fix/standalone-nested-imports branch from ed04c12 to 9b1b396 Compare June 2, 2023 21:03
@JeanMeche

JeanMeche commented Jun 2, 2023

Copy link
Copy Markdown
Member Author

Duplicate with #50559
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JeanMeche JeanMeche closed this Jun 2, 2023
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 3, 2023

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 3, 2023
@JeanMeche
JeanMeche deleted the fix/standalone-nested-imports branch July 12, 2023 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug (or Docs Bug?): Unable to test recursive standalone component due to NG0300

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JeanMeche
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.