Description

james-schwartzkopf

opened on Apr 4, 2020

Issue body actions

🚀 Feature request

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Description

Currently the anyComponentStyle budget applies to all components. However we have a couple of components that significantly exceed the budget. We'd like to make an exception for those components, but still get warnings/errors if other components go over budget.

Describe the solution you'd like

A way to either specify an exception list to the anyComponentStyle budget, or a way to set a per component budget that would override the anyComponentStyle budget for the specified component.

Describe alternatives you've considered

We've upped our budget, but the components in question are considerably larger than our average, so the budget is now pretty much useless.

Reacted by Marvin Luchs, François Dexemple, SteveRob2k, Viachaslau, Sebskyo, Yohan M., Jesse Attas, Leon Radley, Alexandre Brina, Max Hovens and 3 more

Activity

1. alan-agius4

   added

   area: @angular-devkit/build-angular

   featureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issues

   on Apr 4, 2020
2. ngbot

   modified the milestone: Backlog on Apr 4, 2020
3. luchsamapparat commented on Apr 9, 2020

   

   luchsamapparat

   on Apr 9, 2020

   More actions

   I agree. Our component styles are usually very small. However, we have one component that wraps a third-party component which comes along with its own CSS. I could of course include those styles in my styles.css oder via the styles property in my angular.json. However, with those solutions, the integration of the third-party component would spread across the project instead of being encapsulated by the one component.
4. alan-agius4

   added

   devkit/build-angular:browser

   on May 29, 2020
5. kyliau

   added

   triage #1

   help wantedLabel noting an issue which the team is looking for contribution from the community to fixLabel noting an issue which the team is looking for contribution from the community to fix

   on May 29, 2020
6. BruneXX commented on Aug 25, 2020

   

   BruneXX

   on Aug 25, 2020

   More actions

   I'm facing the same issue, and also I'm using this because angular universal because I can''t found a way to defer styles on load with preload, prefetch or preconnect...
7. markusheinemann commented on Dec 18, 2020

   

   markusheinemann

   on Dec 18, 2020

   More actions

   Is there already a discussion on how we can implement this feature? My idea is to add a property like ignorePattern in the budgets section of angular.json. This property accepts an array of regex patterns which components should be ignored. What do you think about this?
8. stagefright5 commented on Jan 5, 2021

   

   stagefright5

   on Jan 5, 2021

   More actions

   @markuscodes1 , I do not think the pattern is a suitable approach because, patterns are usually applicable for a group of things and people usually want to name the component styles that should be excluded. These component styles usually do not belong to a group. So, a property such as ignoreComponents which takes an array of paths referring to the component that has to be excluded would make more sense.
9. alan-agius4 commented on Feb 2, 2021

   

   alan-agius4

   on Feb 2, 2021

   Collaborator

   More actions

   HI all,

   Let's continue tracking this issue #13393

   Thanks.
10. alan-agius4

    closed this as completedon Feb 2, 2021
11. angular-automatic-lock-bot commented on Mar 5, 2021

    

    angular-automatic-lock-botBot

    on Mar 5, 2021

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
12. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Mar 5, 2021

Issue actions