GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(@angular-devkit/build-angular): allow @angular/core version 0.0.0 by gregmagolan · Pull Request #16267 · angular/angular-cli

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

Allow version "0.0.0" for integration testing in the angular/angular repository with the generated development @angular/core npm package which is versioned "0.0.0".

This is a pre-req for angular/angular#33927 which runs integration tests against the bazel generated npm packages.

To green up that PR I have a patch that does the same thing https://github.com/angular/angular/pull/33927/files#diff-817b74474f8a65162b6115d04a6f43c7 which will get removed once this change makes it in to the next release

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gregmagolan
gregmagolan requested a review from IgorMinar November 22, 2019 20:32
@googlebot googlebot added the cla: yes label Nov 22, 2019
@gregmagolan
refactor(@angular-devkit/build-angular): allow @angular/core version …
79cbe71 
…0.0.0

Allow version "0.0.0" for integration testing in the angular/angular repository with the generated development @angular/core npm package which is versioned "0.0.0".
This is a pre-req for angular/angular#33927 which runs integration tests against the bazel generated npm packages.
@gregmagolan gregmagolan changed the title feat: allow @angular/core version 0.0.0 refactor(@angular-devkit/build-angular): allow @angular/core version 0.0.0 Nov 22, 2019
@gregmagolan
gregmagolan requested review from clydin and removed request for IgorMinar November 22, 2019 20:44
clydin
clydin approved these changes Nov 22, 2019
View reviewed changes
@clydin clydin added the target: patch This PR is targeted for the next patch release label Nov 22, 2019
@gregmagolan gregmagolan added area: @angular-devkit/build-angular target: patch This PR is targeted for the next patch release type: refactor and removed target: patch This PR is targeted for the next patch release labels Nov 22, 2019
alan-agius4
alan-agius4 approved these changes Nov 22, 2019
View reviewed changes
@mgechev
mgechev merged commit a4200a0 into angular:master Nov 22, 2019
@gregmagolan gregmagolan mentioned this pull request Nov 24, 2019
build: npm_integration_test && angular_integration_test angular/angular#33927
Closed
3 of 14 tasks
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Dec 23, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes
@clydin clydin clydin approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area: @angular-devkit/build-angular target: patch This PR is targeted for the next patch release type: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@gregmagolan @alan-agius4 @clydin @mgechev @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.