GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(@schematics/angular): add solutions style tsconfig structure by alan-agius4 · Pull Request #17586 · angular/angular-cli

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Apr 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

In version 3.9, TypeScript introduced the concept of "Solutions Style" tsconfig to improve developer experience.

More info: https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-rc/#solution-style-tsconfig

Closes #17493 and closes #8138

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lacolaco, tonivj5, vdumbrav, and SchnWalter reacted with hooray emoji lacolaco and tonivj5 reacted with heart emoji
All reactions
  • 🎉 4 reactions
  • ❤️ 2 reactions
@alan-agius4 alan-agius4 added PR state: blocked target: major This PR is targeted for the next major release labels Apr 30, 2020
@googlebot googlebot added the cla: yes label Apr 30, 2020
@alan-agius4 alan-agius4 changed the title wip! add solutions tsconfig feat(@schematics/angular): add solutions style tsconfig structure May 4, 2020
@alan-agius4
alan-agius4 marked this pull request as ready for review May 6, 2020 12:52
@alan-agius4 alan-agius4 added this to the V10-candidates milestone May 6, 2020
@alan-agius4
alan-agius4 requested review from IgorMinar and clydin and removed request for IgorMinar May 6, 2020 16:46
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 6, 2020
@alan-agius4

alan-agius4 commented May 7, 2020

Copy link
Copy Markdown
Collaborator Author

Blocking until support for TS 3.9 is landed in the framework. None the less, we should get this in a ready to be merged when that happens.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alan-agius4 alan-agius4 removed the PR state: blocked label May 18, 2020
@alan-agius4 alan-agius4 mentioned this pull request May 19, 2020
Use Solution Style tsconfig.json Files #17758
Closed
5 of 15 tasks
clydin
clydin reviewed May 19, 2020
View reviewed changes
Comment thread tests/legacy-cli/e2e/utils/project.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kyliau

kyliau commented May 19, 2020

Copy link
Copy Markdown
Contributor

We had a discussion whether the filename convention should be tsconfig-base.json or tsconfig.base.json. The former follows the same pattern used in the TS repo, whereas the latter allows the Angular workspace to enforce a consistent file naming.
Another concern is the convention used in google3. However, since google3 does not have plan to introduce solution-style tsconfig, the consideration is moot here.
We've decided to with tsconfig.base.json to ensure a consistent naming across Angular workspace.
cc: @IgorMinar
alan-agius4, tonivj5, and IgorMinar reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clydin
clydin approved these changes May 20, 2020
View reviewed changes
alan-agius4 added 2 commits May 20, 2020 13:06
@alan-agius4
refactor: rename tsconfig.json to tsconfig.base.json
7469b94
@alan-agius4
feat(@schematics/angular): add solutions style tsconfig structure
359d76e 
In version 3.9, TypeScript introduced the concept of "Solutions Style" tsconfig to improve developer experience.

More info: https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-rc/#solution-style-tsconfig

Closes #17493 and closes #8138
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker hotlist: release-blocker and removed action: merge The PR is ready for merge by the caretaker labels May 20, 2020
IgorMinar
IgorMinar approved these changes May 20, 2020
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread integration/angular_cli/tsconfig.base.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 20, 2020
@IgorMinar

IgorMinar commented May 20, 2020

Copy link
Copy Markdown
Contributor

We've decided to with tsconfig.base.json to ensure a consistent naming across Angular workspace.

Sounds great! thanks for documenting the decision making process.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mgechev
mgechev merged commit bede232 into angular:master May 20, 2020
@alan-agius4
alan-agius4 deleted the solutions-tsconfig branch May 20, 2020 19:16
@kyliau kyliau mentioned this pull request May 29, 2020
Language service not loading with config option "files: []" angular/vscode-ng-language-service#793
Closed
@alan-agius4 alan-agius4 mentioned this pull request Jun 8, 2020
Paths decalred in compilerOptions tsconfig.app.json not working #17873
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 20, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes
+1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker hotlist: release-blocker target: major This PR is targeted for the next major release

Projects

None yet

Milestone

V10-candidates

Development

Successfully merging this pull request may close these issues.

Wrong jasmine/wd2 typings in Angular 8/9 tsconfig paths and module resolution errors in VS Code

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@alan-agius4 @kyliau @IgorMinar @clydin @mgechev @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.