GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(@angular-devkit/schematics): update zone.js to 0.11.8 and add async tagging API support by JiaLiPassion · Pull Request #23750 · angular/angular-cli

Conversation

JiaLiPassion commented Aug 16, 2022

Copy link

Copy Markdown

Contributor

Update to zone.js 0.11.8
import 'zone.js/plugins/async-stack-tagging in development mode
to support async tagging API for better debugging experience.

For more information, please refer to this PR angular/angular#46693

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JiaLiPassion requested review from alan-agius4 and mgechev

August 16, 2022 07:16

JiaLiPassion force-pushed the zone-async-stagging branch from fcdc1d7 to 0baea55 Compare

August 16, 2022 07:18

alan-agius4 commented Aug 16, 2022

Copy link

Copy Markdown

Collaborator

Can you please change the scope to @schematics/angular?

Thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          feat(@schematics/angular): update zone.js to 0.11.8 and add async tag…

690b433

…ging API support

1. Update to `zone.js` 0.11.8
2. `import 'zone.js/plugins/async-stack-tagging` in `development` mode
to support `async tagging API` for better debugging experience.

For more information, please refer to this PR angular/angular#46693

JiaLiPassion force-pushed the zone-async-stagging branch from 0baea55 to 690b433 Compare

August 16, 2022 07:46

JiaLiPassion commented Aug 16, 2022

Copy link

Copy Markdown

Contributor Author

@alan-agius4 , sure, updated, thank you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 reviewed

Aug 16, 2022

View reviewed changes

Comment thread

packages/schematics/angular/application/files/src/environments/environment.ts.template

		* on performance if an error is thrown.
		*/
		// import 'zone.js/plugins/zone-error'; // Included with Angular CLI.
		import 'zone.js/plugins/async-stack-tagging'; // Included with Angular CLI to support async stack tagging API.

alan-agius4 Aug 16, 2022

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should this be enabled by default or commented out like the above line and users can opt-in? Does it have any side effects of having this enabled for production?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JiaLiPassion Aug 16, 2022

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4

I believe this one should be included in the development mode by default since this need to integrate with Angular Devtools.
in production mode, if we enable it, it will have a little impact to the performance, since it will add a new parent Zone to the ngZone, just like TaskTackingZone.
@mgechev , could you confirm my understanding is correct? Thank you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

alan-agius4 Aug 16, 2022

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment there is no way to conditionally include polyfills based on if it’s development/production.

I think a better approach would be to add zone-error and async-stack-tagging internally in the builder so that we can conditionally add this based on if the build is optimized not.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mgechev Aug 16, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like to enable it by default in development so folks can get complete stack traces and not use it in production. Async stack tagging (AST) is independent from Angular DevTools and we use it to concatenate async stack traces so that we can give the entire picture to developers.

AST is very similar to Zone's long stack traces with the difference that they work with debugging tools out of the box.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

alan-agius4 added target: minor

This PR is targeted for the next minor release

needs: discussion On the agenda for team meeting to determine next steps labels

Aug 16, 2022

alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label

Sep 22, 2022

JiaLiPassion commented Sep 22, 2022

Copy link

Copy Markdown

Contributor Author

This is handled by angular/angular#47416.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JiaLiPassion closed this

Sep 22, 2022

angular-automatic-lock-bot Bot commented Oct 23, 2022

Copy link

Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators

Oct 23, 2022

Reviewers

alan-agius4

alan-agius4 left review comments

mgechev

Awaiting requested review from mgechev

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

target: minor

This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.