GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(@angular/build): only generate shallow preload links for initial files by clydin · Pull Request #27581 · angular/angular-cli

Conversation

@clydin

@clydin clydin commented May 2, 2024

Copy link
Copy Markdown
Member

To remove the potential for a large amount of modulepreload link elements being added to the generating index.html for an application, the number of elements is now limited to five. Also, only first-level initial scripts will be added. Previously all initial scripts regardless of depth were eligible for preloading. The preload generation can still be fully disabled via the index.preloadInitial option within the build options.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 2, 2024
@clydin
clydin marked this pull request as ready for review May 2, 2024 15:08
@clydin
clydin requested a review from alan-agius4 May 2, 2024 15:08
alan-agius4
alan-agius4 approved these changes May 2, 2024
View reviewed changes

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: the scope should be @angular/build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clydin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
alan-agius4
alan-agius4 reviewed May 2, 2024
View reviewed changes
Comment thread packages/angular/build/src/tools/esbuild/bundler-context.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@clydin
clydin force-pushed the application/shallow-preloads branch 2 times, most recently from 47c73ca to f2ae94f Compare May 2, 2024 15:44
@clydin clydin changed the title fix(@angular-devkit/build-angular): only generate shallow preload links for initial files fix(@build/angular): only generate shallow preload links for initial files May 2, 2024
@clydin clydin changed the title fix(@build/angular): only generate shallow preload links for initial files fix(@angular/build): only generate shallow preload links for initial files May 2, 2024
@clydin
fix(@angular/build): only generate shallow preload links for initial …
131fdb5 
…files

To remove the potential for a large amount of modulepreload link elements being added
to the generating `index.html` for an application, the number of elements is now limited
to three. Also, only first-level initial scripts will be added. Previously all initial
scripts regardless of depth were eligible for preloading. The preload generation can
still be fully disabled via the `index.preloadInitial` option within the build options.
@clydin
clydin force-pushed the application/shallow-preloads branch from f2ae94f to 131fdb5 Compare May 2, 2024 15:50
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label May 2, 2024
@clydin
clydin merged commit 82e9e68 into angular:main May 2, 2024
@clydin
clydin deleted the application/shallow-preloads branch May 2, 2024 16:22
@alan-agius4 alan-agius4 mentioned this pull request May 6, 2024
Excessive modulepreload Links in Angular 18.0.0-next.4 Affecting Performance Metrics #27490
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 2, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clydin @alan-agius4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.