GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(@angular/build): include component test metadata in development builds by clydin · Pull Request #30021 · angular/angular-cli

Conversation

@clydin

@clydin clydin commented Apr 3, 2025

Copy link
Copy Markdown
Member

To support the usage of AOT with unit tests, development builds of applications will now include injected calls to the internal Angular setClassMetadata function. These calls add metadata to each component that can be leveraged by the TestBed to override component information.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clydin
fix(@angular/build): include component test metadata in development b…
dd72451 
…uilds

To support the usage of AOT with unit tests, development builds of applications
will now include injected calls to the internal Angular `setClassMetadata`
function. These calls add metadata to each component that can be leveraged
by the `TestBed` to override component information.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Apr 3, 2025
@angular-robot angular-robot Bot added the area: @angular/build label Apr 3, 2025
@clydin
clydin requested a review from alan-agius4 April 3, 2025 15:07
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 3, 2025
alan-agius4
alan-agius4 approved these changes Apr 3, 2025
View reviewed changes
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2025
@alan-agius4 alan-agius4 linked an issue Apr 3, 2025 that may be closed by this pull request
New AOT option for Karma doesn't play nicely with TestBed.overrideComponent #30017
Closed
1 task
@clydin
clydin merged commit 6f913ad into angular:main Apr 3, 2025
@clydin

clydin commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

The changes were merged into the following branches: main, 19.2.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clydin
clydin deleted the application/include-test-metadata branch April 3, 2025 18:35
@JeanMeche JeanMeche mentioned this pull request Apr 17, 2025
Angular 19 forRoot() gets called twice in developer build (v18 only once) angular/angular#60905
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented May 4, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New AOT option for Karma doesn't play nicely with TestBed.overrideComponent

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clydin @alan-agius4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.