GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — fix(@angular/build): preserve component initialization in Karma test bundles by nagahara-naoki · Pull Request #34668 · angular/angular-cli ConversationPR Checklist
PR Type
What is the current behavior?Fixes #34250. With The regression fixture includes:
Against main ( What is the new behavior?The Karma build routes the discovered spec entry points through a shared virtual module that imports all selected specs. This keeps spec initialization in one module graph, avoiding the problematic partitioning across independent spec entry points.
The same four browser specs now all pass. The added integration test exercises real Karma/Chrome execution rather than only checking generated bundle text. Does this PR introduce a breaking change?
Other informationSimply setting Validation on macOS arm64, Node.js 24.22.2, pnpm 12.16.1, and Chrome Headless 159:
The full repository and E2E suites were not run. Large-suite build size/performance and dynamic addition of spec files during watch mode were not separately benchmarked or validated.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…bundles Load selected Karma specs through a shared virtual module while retaining spec entry names and shared framework chunks. Add a browser regression for barrel imports combined with async specs. Fixes angular#34250 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code ReviewThis pull request updates the Karma application builder to group spec files into a single module graph using a virtual module plugin. This prevents cross-chunk lazy initialization from exposing uninitialized barrel exports. Additionally, a behavior test is added to verify barrel imports with async tests. The review feedback suggests appending the collected spec files to
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To prevent potentially overwriting any existing buildOptions.rootFiles = buildOptions.rootFiles ? [...buildOptions.rootFiles, ...specFiles] : specFiles;
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. karma builder: component imported through a barrel is undefined in TestBed when another spec has an async test (cross-chunk lazy init, karma counterpart of #33728)Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |