GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(@schematics/angular): set explicit type for the application root component by nagahara-naoki · Pull Request #34685 · angular/angular-cli ConversationPR Checklist
PR Type
What is the current behavior?When the workspace sets Issue Number: Closes #34684 What is the new behavior?Pass an explicit empty The 2016 branch continues to pass The new E2E test sets the workspace component type, generates and builds applications using both naming styles, checks their stylesheet references and the absence of the incorrectly named root component, and verifies that a separately generated component still uses the workspace type. Does this PR introduce a breaking change?
Other informationValidated locally against
Commands: pnpm bazel test //tests:e2e_node24 \ --config=e2e --config=no-sharding \ --test_filter='tests/generate/{application/application-workspace-type-default,schematic-defaults}.ts' \ --test_arg=--esbuild --nocache_test_results pnpm bazel test //packages/schematics/angular:test --config=no-sharding The full CLI repository test suite was not run.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…component Pass an empty type for the 2025 application root component so workspace component defaults cannot produce filenames that differ from the application templates. Keep the 2016 naming behavior and ordinary component defaults intact. Add an E2E regression test that builds both naming styles with a workspace type configured and verifies that separate component generation still uses that type. Closes angular#34684 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code ReviewThis pull request updates the Angular application schematic to set
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. ng generate application produces a missing stylesheet when a workspace component type is configured
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |