GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — feat(@angular/cli): make appRoot customizable by vsavkin · Pull Request #7775 · angular/angular-cli Conversation
Contributor
Currently, the CLI hardcodes appRoot to In complex projects with many apps (some of which aren't actually bundles shipped to the client), the prefix gets in a way. It looks awkward. Using schematics we can generate apps that do not follow the default. Currently if you do that, The PR changes the CLI to allow the provisioning of
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Brocco
suggested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only a few minor things.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Creating local variable
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed it. Bad rebase.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New import is not being used.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed it
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not required, but would be nice to have:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My thinking is: since this function is called by a single caller, it would make it unnecessary complex. But I can make a change, if you think it is better this way.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
vsavkin
force-pushed
the
make_app_customizable
branch
2 times, most recently
from
1dea1bf to
10b0478
Compare
vsavkin
force-pushed
the
make_app_customizable
branch
from
10b0478 to
e6b1eb6
Compare
Brocco
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
This was referenced
Closed
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
| |||||||||||||||||||||||||||||||||||||||||||||||
There was an error while loading. Please reload this page.
|
i need ng generate module in newapp folder? how it is possble? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Brocco I think the wiki for config schema should be updated accordingly。 https://github.com/angular/angular-cli/wiki/angular-cli For I just come to this issue from that wiki. Thx~ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
How would you target a new module or component to a specific app? I guess this works "ng g module app2/new-module" |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
How do I use this? Is there any documentation on appRoot? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most ng subcommand have an option "--app" to specify the name of app. No document get updated as I mentioned above. But you can use it this way for an app "common" sibling to the default "app". }, { "name": "common", "appRoot": "common", "root": "src", "tsconfig": "tsconfig.app.json", |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Do you have any idea how we have to configure with Angular 6 "angular.json" config? Thank you very much! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Using |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.