GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Avoid handling promise rejections twice in stability helper by atscott · Pull Request #3657 · angular/angularfire

Conversation

@atscott

@atscott atscott commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

PendingTasks.run reports rejections of the promise to the ErrorHandler. This function already returns a promise that is meant to be handled in the developer's application. If there is handling there, the rejection is handled both in the PendingTasks.run and in the developer callsite.

This change updates the code to use PendingTasks.add instead, which has no built in error handling mechanisms.

fixes angular/angular#61932

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LanderBeeuwsaert reacted with hooray emoji Exac reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction
@atscott
fix: Avoid handling promise rejections twice in stability helper
695d4c5 
`PendingTasks.run` reports rejections of the promise to the
`ErrorHandler`. This function already returns a promise that is meant to
be handled in the developer's application. If there _is_ handling there,
the rejection is handled both in the `PendingTasks.run` and in the
developer callsite.

This change updates the code to use `PendingTasks.add` instead, which
has no built in error handling mechanisms.

fixes angular/angular#61932
jamesdaniels
jamesdaniels approved these changes Jun 6, 2025
View reviewed changes
@jamesdaniels
jamesdaniels merged commit eb99d8e into angular:main Jun 12, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Sep 16, 2026
chore(deps): migrate to Angular 22, Nx 23.2.1, TypeScript 6 and Node 24 WolfSoko/wol-sok-mono#2350
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jamesdaniels jamesdaniels jamesdaniels approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@angular/fire and its use of PendingTasks.run causes promise rejections to be handled twice

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@atscott @jamesdaniels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.