GeezerVison is showing github.com — chore: bump version to 21.0.0-rc.1 by armando-navarro · Pull Request #3751 · angular/angularfire
Conversation
Checklist
- Issue number for this PR: none, release mechanics for the 21.0.0-rc.1 cut
- Docs included?: only the sample README's install example, which names the tarball version
- Test units included?: no, version literals only
- In a clean directory,
yarn install, yarn test run successfully?: not applicable, no source changed
Description
Bumps the root package.json version literal to 21.0.0-rc.1 ahead of the release tag. The publish workflow reads this literal to name the npm release.
The sample consumes the library as file:../angular-fire-<version>.tgz, so its package.json dependency path and the install example in its README are bumped to the same version in this change.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The publish job reads this literal at tag time. The sample's file:
tarball dependency path and its README install example carry the
same version, so they move together.
tyler-reitz
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving.
One non-blocking thing before you cut the tag: root package-lock.json still records 21.0.0-rc.0, in both the top-level version and packages[""].version. The v20 cut (c1c6af9) moved them together with package.json. CI will not catch it: npm ci exits 0 on a root-version-only mismatch, though it does exit 1 on a dependency mismatch, so the check is not dead. The cost is a stray diff in someone's unrelated PR later, since the next root npm install rewrites that field. Both behaviours checked against npm, not inferred. npm install --package-lock-only covers it.
sample/package-lock.json still names the rc.0 tarball, which makes npm ci in sample/ fail EUSAGE, but the README says to install the tarball by name and leave that lockfile uncommitted, so I read it as intended.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
jhuleatt
jhuleatt approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|