GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(build): name canaries after the release, not after a prerelease by armando-navarro · Pull Request #3767 · angular/angularfire Conversation
Collaborator
Fixes #3766 These changes take us back to the release candidate pattern this repo used up until #3674, after which Details
VerificationEvery naming path was run against the real script.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe root version field held `21.0.0-rc.1`, so every merge to main published `21.0.0-rc.1-canary.<sha>`. Semver ranks that above `21.0.0-rc.1`, and the caret range `ng add` writes into a user's package.json then resolves to the canary instead of the release candidate they asked for. Releases through v20 avoided this by keeping the plain release number in the version field and publishing prereleases from their own git tag, which is what the publish job reads. This restores that: the field returns to `21.0.0`, and build.sh drops any prerelease part when naming a canary, so a prerelease written there again cannot produce a canary that outranks it. The schematics comment and its log line no longer say a prerelease range matches canary builds, which stops being true here. The sample's lockfile still named `angular-fire-21.0.0-rc.0.tgz`, two releases behind its own package.json, so `npm ci` there failed on the mismatch. Regenerated by building the library and running `npm install ../angular-fire-21.0.0.tgz` in sample/. It also picks up the `^21.2.0` peer ranges the Angular 21.2 raise introduced.
tyler-reitz
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Approving. Every naming path reproduces: I ran this branch's One thing for the release notes rather than for this PR. The 25 canaries already on npm outrank every future rc of
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
bump: patch
ProjectsDevelopmentSuccessfully merging this pull request may close these issues. Canary builds are named after the release candidate, so npm ranks them above itUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |