GeezerVison is showing github.com — docs: note the removed @angular/platform-server peer in the v21 upgrade guide by armando-navarro · Pull Request #3795 · angular/angularfire
Conversation
Refs #3667
Adds the removal of the optional @angular/platform-server peer (#3792) to the "Other notes" list in docs/version-21-upgrade.md, next to the existing note about @angular/platform-browser-dynamic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…de guide
The upgrade guide's "Other notes" already lists the removed
@angular/platform-browser-dynamic peer. The optional
@angular/platform-server peer is gone too, and apps need no change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks right, so I am holding the approval rather than giving it, since approval is the only gate here and it would make this mergeable ahead of rc.2. Ping me when rc.2 is ready and I will approve it then.
Two small things while it waits.
The sentence says "peer dependency" twice. Reads better collapsed:
The obsolete @angular/platform-browser-dynamic and the unused optional @angular/platform-server peer dependencies were removed. No action is needed.
And @angular/platform-browser-dynamic is already gone from published 20.1.0, so for anyone upgrading from latest that half of the bullet describes something their current version already did. Worth either saying which removal landed when, or leaving it, since "No action is needed" covers both either way. Your call, it is the sentence this PR happens to touch rather than anything it introduces.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The line said "peer dependency" twice. Naming both packages before one "peer dependencies" reads better.
|
@tyler-reitz This is a draft PR, so an approval doesn't make it mergeable until I pull it out of draft state. If it looks good, could you approve it like you did a previous draft PR I wanted held for a release? It stays a draft until 21.0.0-rc.2 is ready to release, which is very soon.
I took your first suggestion, so the line names "peer dependencies" once. I'm leaving the second as it is, since "No action is needed" holds for readers coming from either 20.0.x or 20.1.0.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving while it is still a draft, per the rc.2 hold in the description. The combined note reads correctly coming from either 20.0.x or 20.1.0.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The example named 21.0.0-rc.1, which would install the older release
candidate once 21.0.0-rc.2 is out.
…uide
21.0.0-rc.2 skips App Check during server rendering (angular#3773). The guide
now says so and links the App Check page's server-rendering section.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|
tyler-reitz
left a comment