Description

nstuyvesant

opened on Sep 1, 2017

Issue body actions

• I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.

Item	Version
generator-angular-fullstack	4.2.2
Node	8.4.0
npm	5.3.0
Operating System	OS X 10

Item	Answer
Transpiler	Babel
Markup	Pug
CSS	SCSS
Router	ngRoute
Client Tests	Mocha
DB	SQL
Auth	Y

Got this error after scaffolding a project and running gulp test:

events.js:182
      throw er; // Unhandled 'error' event
      ^
TypeError: The "digest" argument is required and must not be undefined
  at pbkdf2 (crypto.js:635:11)
  at Object.exports.pbkdf2 (crypto.js:623:10)
  at Instance.encryptPassword (/Users/nates/dev/test/server/api/user/user.model.js:187:33)
  at /Users/nates/dev/test/server/api/user/user.model.js:219:18
  at RandomBytes.ondone (/Users/nates/dev/test/server/api/user/user.model.js:160:18)

Seems like the function calls on line 183 of user.model(sequelizeModels).js and line 187 need to specify the digest for newer versions of node.

Activity

1. Awk34 commented on Sep 1, 2017

   

   Awk34

   on Sep 1, 2017

   Collaborator

   More actions

   Correct. Node used to default it to 'sha1', so if you already have passwords hashed, use that option. Otherwise you can run node --print --eval "require('crypto').getHashes()" in a console to see a list of hashing algorithms that your current version supports. We should set it to 'sha1' in version 4.x.x so that it doesn't break anyone, and also set a new default in the canary branch for 5.0.0. The new Node docs show 'sha512' in the examples.
2. Awk34

   self-assigned this

   on Sep 1, 2017
3. Awk34

   added

   V4

   V5

   on Sep 1, 2017
4. nstuyvesant commented on Sep 1, 2017

   

   nstuyvesant

   on Sep 1, 2017

   ContributorAuthor

   More actions

   Makes sense - thanks!
5. Awk34

   added a commit that references this issue on Sep 1, 2017

   fix(server:auth): specify digest for pbkdf2

   This issue will close once commit 689c3fc is merged into the 'master' branch.

   689c3fc
6. Awk34

   closed this as completedin #2629on Sep 3, 2017

Issue actions