GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — global config settings by pawelwojkiewicz · Pull Request #309 · angular-split/angular-split

Conversation

@pawelwojkiewicz

@pawelwojkiewicz pawelwojkiewicz commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

This PR resolve the issue from: #166

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pawelwojkiewicznp added 3 commits October 18, 2021 09:33
@pawelwojkiewicznp
global config settings
e79819f
@pawelwojkiewicznp
changed interface name and property to private
f780445
@pawelwojkiewicznp
changed config property to private
96d52eb
beeman
beeman suggested changes Nov 20, 2021
View reviewed changes
Comment thread projects/angular-split/src/lib/component/split.component.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@beeman

beeman commented Nov 20, 2021

Copy link
Copy Markdown
Contributor

@pawelwojkiewicz it looks like this change breaks the other demo pages if the global config is not provided, could you look into this.

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pawelwojkiewicznp added 2 commits November 25, 2021 15:08
@pawelwojkiewicznp
added Optional addnotation to Inject
b1ffdfc
@pawelwojkiewicznp
removed ts-ignore comment
7731a5e
@pawelwojkiewicz

pawelwojkiewicz commented Nov 25, 2021 via email •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author
Hello beeman. You're right - there was missing @optional() additional to @Inject. I've added this. I also removed ts-ignore comment. Now everything should be fine.
beeman reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@beeman

beeman commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Hello beeman. You're right - there was missing @optional() additional to @Inject. I've added this. I also removed ts-ignore comment. Now everything should be fine.

Thanks! Can you rebase over the latest main branch? It updated to Angular 13 in the meanwhile
pawelwojkiewicz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pawelwojkiewicznp added 2 commits November 26, 2021 09:36
@pawelwojkiewicznp
Merge branch 'main' into beeman/global-config
c97490c 
# Conflicts:
#	projects/angular-split/src/public_api.ts
@pawelwojkiewicznp
added missed injection token
469ce20
@pawelwojkiewicz

pawelwojkiewicz commented Nov 26, 2021 via email

Copy link
Copy Markdown
Contributor Author
Done. czw., 25 lis 2021 o 21:52 beeman ***@***.***> napisał(a):
…
Hello beeman. You're right - there was missing @optional <https://github.com/optional>() additional to @Inject <https://github.com/Inject>. I've added this. I also removed ts-ignore comment. Now everything should be fine. Thanks! Can you rebase over the latest main branch? It updated to Angular 13 in the meanwhile — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#309 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIWULPFM7JZNYZ7OEKN6N3UN2OZFANCNFSM5GF5UECA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pawelwojkiewicznp added 2 commits November 26, 2021 18:50
@pawelwojkiewicznp
moved IDefaultOptions to interface.ts
6242972
@pawelwojkiewicznp
fixed IDefaultOptions import
617004b
beeman
beeman approved these changes Nov 26, 2021
View reviewed changes
@beeman
beeman merged commit 65a11d7 into angular-split:main Nov 26, 2021
@github-actions github-actions Bot mentioned this pull request Jan 24, 2024
chore(main): release angular-split 17.2.0 #389
Closed
@Jefiozie

Jefiozie commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

@all-contributors please add @pawelwojkiewicz for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@allcontributors allcontributors Bot mentioned this pull request Jan 24, 2024
docs: add pawelwojkiewicz as a contributor for code #399
Merged
@allcontributors

allcontributors Bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

@Jefiozie

I've put up a pull request to add @pawelwojkiewicz! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jan 24, 2024
chore(main): release angular-split 17.2.0 #418
Merged
@fjaguado fjaguado mentioned this pull request Jul 19, 2024
[Snyk] Upgrade angular-split from 17.1.1 to 17.2.0 systelab/systelab-components#890
Closed
@stephanebouget

stephanebouget commented Oct 18, 2024

Copy link
Copy Markdown

Hello, is there a documentation to see how to use it ?
ty!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Harpush

Harpush commented Oct 18, 2024

Copy link
Copy Markdown
Collaborator

Hello, is there a documentation to see how to use it ? ty!

Before the 18 beta or on beta?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stephanebouget

stephanebouget commented Oct 18, 2024

Copy link
Copy Markdown

Hello, is there a documentation to see how to use it ? ty!

Before the 18 beta or on beta?

On the 18 beta
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Harpush

Harpush commented Oct 18, 2024

Copy link
Copy Markdown
Collaborator

Hello, is there a documentation to see how to use it ? ty!

Before the 18 beta or on beta?

On the 18 beta

There is no updated documentation for the beta yet unfortunately.
To use global config on the beta you should import provideAngularSplitOptions
stephanebouget reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@beeman beeman beeman approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@pawelwojkiewicz @beeman @Jefiozie @stephanebouget @Harpush @pawelwojkiewicznp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.