GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: change default area size from null to * by Harpush · Pull Request #358 · angular-split/angular-split

Conversation

@Harpush

@Harpush Harpush commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

Currently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (kind of multiple wildcards).

This change make split areas without size work again even though this is invalid. The problem can be seen in the collapse example which has no tests coverage (another issue for another time).

We should think how to handle it - size required? Support multiple wildcards?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Harpush
fix: change default area size from null to *
edcb817
@Harpush
Harpush requested a review from beeman September 5, 2023 05:58
@beeman
beeman merged commit 21f1004 into angular-split:main Sep 5, 2023
@Harpush
Harpush deleted the fix-default-size-wildcard branch September 6, 2023 17:22
This was referenced Jan 24, 2024
chore(main): release angular-split 17.2.0 #389
Closed
chore(main): release angular-split 17.2.0 #418
Merged
@github-actions github-actions Bot mentioned this pull request Feb 26, 2024
chore(main): release 15.1.0 #431
Closed
@github-actions github-actions Bot mentioned this pull request May 2, 2024
chore(main): release 15.1.0 #437
Closed
@fjaguado fjaguado mentioned this pull request Jul 19, 2024
[Snyk] Upgrade angular-split from 17.1.1 to 17.2.0 systelab/systelab-components#890
Closed
@github-actions github-actions Bot mentioned this pull request Oct 19, 2024
chore(main): release 15.1.0 #457
Closed
@github-actions github-actions Bot mentioned this pull request Nov 4, 2024
chore(main): release 18.0.0 #466
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeman beeman Awaiting requested review from beeman

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Harpush @beeman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.