GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: keep minSize, even when size is undefined by Gwe-n · Pull Request #259 · angular-split/angular-split

Conversation

@Gwe-n

@Gwe-n Gwe-n commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Fix #255

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Gwe-n
Fix: Keep minSize, even when size is undefined
3612e25 
Fix angular-split#255
@beeman
beeman changed the base branch from master to main November 22, 2020 03:29
@DerekJDev

DerekJDev commented Jun 25, 2021

Copy link
Copy Markdown

Any ETA on when this will be pushed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gtteamamxx

gtteamamxx commented Aug 25, 2021

Copy link
Copy Markdown

Any updates?
@beeman
wupaz and armandorod2000 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Jefiozie

Jefiozie commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Hi @Gwe-n, recently @beeman handed over the maintenance to myself and @SanderElias.

Could you provide me a update on this PR and resolve the conflicts? After this we will review your PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Jefiozie
Jefiozie requested review from Jefiozie and SanderElias January 22, 2024 11:54
@Jefiozie Jefiozie added the waiting-for-reply Waiting for reply or confirmation of user creating the issue. label Jan 22, 2024
@Gwe-n
Merge branch 'main' into fix-min-size
f0ba132
@Gwe-n

Gwe-n commented Jan 22, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Jefiozie I have resolved the conflicts in question. I must admit that this subject is now far from my mind 😅 Don't hesitate to close this PR if the patch doesn't fix the issue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Jefiozie Jefiozie removed the waiting-for-reply Waiting for reply or confirmation of user creating the issue. label Jan 22, 2024
Gwe-n and others added 2 commits January 22, 2024 15:07
@Gwe-n
Update split.component.ts
55be44b
@Jefiozie
Merge branch 'main' into fix-min-size
3546ece
@Jefiozie Jefiozie changed the title Fix: Keep minSize, even when size is undefined fix: keep minSize, even when size is undefined Jan 24, 2024
Jefiozie
Jefiozie approved these changes Jan 24, 2024
View reviewed changes

@Jefiozie Jefiozie left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Jefiozie

Jefiozie commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

@SanderElias could you also do a review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SanderElias
SanderElias approved these changes Jan 25, 2024
View reviewed changes
@SanderElias
SanderElias merged commit bc139ee into angular-split:main Jan 25, 2024
@Jefiozie

Jefiozie commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

@all-contributors please add @Gwe-n for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@allcontributors allcontributors Bot mentioned this pull request Jan 25, 2024
docs: add gwe-n as a contributor for code #419
Merged
@allcontributors

allcontributors Bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

@Jefiozie

I've put up a pull request to add @Gwe-n! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Gwe-n
Gwe-n deleted the fix-min-size branch January 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanderElias SanderElias SanderElias approved these changes
@Jefiozie Jefiozie Jefiozie approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minSize doesn't work

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Gwe-n @DerekJDev @gtteamamxx @Jefiozie @SanderElias
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.