GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: aria-valuenow incorrectly set to wildcard by Harpush · Pull Request #368 · angular-split/angular-split

Conversation

@Harpush

@Harpush Harpush commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

Reverts aria-valuenow back to null instead of wildcard. Ideally should be the real value but it is a more involved change and it was never implemented this way to begin with.

Closes #362

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Harpush
fix: aria-valuenow incorrectly set to wildcard
f388ae3
@Harpush
Harpush requested a review from beeman November 28, 2023 22:33
kainiedziela
kainiedziela approved these changes Nov 29, 2023
View reviewed changes
beeman
beeman approved these changes Nov 29, 2023
View reviewed changes
@beeman
beeman merged commit bcb4aa0 into angular-split:main Nov 29, 2023
@beeman

beeman commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Thanks, @Harpush - this has been released as 17.1.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 24, 2024
chore(main): release angular-split 17.2.0 #389
Closed
chore(main): release angular-split 17.2.0 #418
Merged
@github-actions github-actions Bot mentioned this pull request Feb 26, 2024
chore(main): release 15.1.0 #431
Closed
@github-actions github-actions Bot mentioned this pull request May 2, 2024
chore(main): release 15.1.0 #437
Closed
@fjaguado fjaguado mentioned this pull request Jul 19, 2024
[Snyk] Upgrade angular-split from 17.1.1 to 17.2.0 systelab/systelab-components#890
Closed
@github-actions github-actions Bot mentioned this pull request Oct 19, 2024
chore(main): release 15.1.0 #457
Closed
@github-actions github-actions Bot mentioned this pull request Nov 4, 2024
chore(main): release 18.0.0 #466
Closed
@Harpush
Harpush deleted the fix-aria-valuenow-wildcard branch May 30, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@beeman beeman beeman approved these changes
@kainiedziela kainiedziela kainiedziela approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aria-valuenow set incorrectly when only the second pane is sized

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Harpush @beeman @kainiedziela
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.