GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: update fork with 3.13 changes by RobPasMue · Pull Request #21 · ansys/ansys-pythonnet

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Jan 8, 2025

Copy link
Copy Markdown
Member

Rebasing fork and allowing for Python 3.13 builds

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
filmor and others added 30 commits November 8, 2024 13:50
@filmor
Drop reference to Py_Main (#2504)
0ea1d29 
Was only used in the console and might not be available in some
embedding scenarios.
@filmor
Stick to ubuntu-22.04 for now as that image still contains Mono
7a9e3bf
@filmor
First attempt at Python 3.13
5cf2534
@filmor
Add Python 3.13 to CI
2f3a0e7
@filmor
Update project file
5a7b5be
@filmor
Use PyThreadState_GetUnchecked on Python 3.13
f3face0
@filmor
Workaround for geninterop failure to handle non-pointer fields
88d98f2
@filmor
Bump clr-loader and dev dependencies
4bb673f
@filmor
Raise maximum supported version
8283627
@filmor
Xfail a test that only fails locally on my machine right now
1920b19
@filmor
Skip embed tests on Python 3.13 for now
60a057f 
Verified them locally, but there is an issue with the Github workflow
image that can hopefully be resolved later by using a full venv
instead of relying on the system environment.
@filmor
Add changelog entry
8f0ccb7
@filmor
Workaround for setuptools bug #4759
7c87fec
@filmor
Remove win-x86-py3.13 entirely for now
0ea8e6f
@filmor
Merge pull request #2454 from pythonnet/python3.13
4132a36 
Python 3.13
@filmor
Release 3.0.5
0826fc0
@filmor
Back to dev
f361fa9
@filmor
Drop icon
dfd746b
@koubaa @RobPasMue
Revert "Wrap returned objects in interface if method return type is i…
8ee3d6e 
…nterface"

This reverts commit 1dd36ae.

# Conflicts:
#	src/runtime/Converter.cs
#	src/runtime/methodbinder.cs
#	src/runtime/typemanager.cs
#	src/testing/interfacetest.cs
#	tests/test_interface.py
@koubaa @RobPasMue
update readme
a315f26
@koubaa @RobPasMue
fix merge issue
0c16a4f
@koubaa @RobPasMue
"fix" tests
6a1bef7
@koubaa @RobPasMue
disable assertion
436988a
@koubaa @RobPasMue
Update README.rst
a3eeefe
@jorgepiloto @RobPasMue
FEAT: improve gitignore
e1ee00d
@jorgepiloto @RobPasMue
MAINT: update project metadata
b7864a1
@jorgepiloto @RobPasMue
CI: generate and upload artifacts
b1a01b8
@jorgepiloto @RobPasMue
CI: add release job
a37aaf0
@jorgepiloto @RobPasMue
CI: unify and collect under ci_cd.yml
c2cb59a
@jorgepiloto @RobPasMue
CI: configure concurrent workflows
3b734e2
Mohamed Koubaa and others added 19 commits January 8, 2025 09:53
Mohamed Koubaa @RobPasMue
Use python convention
d7b0830
Mohamed Koubaa @RobPasMue
fix test
e3fed7c
Mohamed Koubaa @RobPasMue
respect base enum type
ceaa141
Mohamed Koubaa @RobPasMue
fix other assert
2051529
Mohamed Koubaa @RobPasMue
refactor
104e442
@jorgepiloto @RobPasMue
fix: ci actions
dfb3c39
@jorgepiloto @RobPasMue
maint: add dependabot.yml file
218b813
@jorgepiloto @RobPasMue
fix: use custom actions
295154e
@RobPasMue
Delete .github/dependabot.yml
9ad52a2
@RobPasMue
fix: cicd issues
116d118
@RobPasMue
fix: use proper branch
467144d
@RobPasMue
fix: cicd
c2a9dbb
Mohamed Koubaa @RobPasMue
add runsettings to gitignore
f368554
Mohamed Koubaa @RobPasMue
Add optional argument to wrap interface in ToPython
76c74e8 
This is used by ToPythonAs in this fork. In the upstream pythonnet,
it is effectively always true
Mohamed Koubaa @RobPasMue
update readme
b4a8830
@RobPasMue
ci: delete ARM workflow (not needed)
41123d9
@RobPasMue
Merge branch 'main' into feat/update-fork
b9c826b
@RobPasMue
ci: align ci_cd with remote main
454a31d
@RobPasMue
feat: rewrite exclude
3b78bf1
@RobPasMue RobPasMue mentioned this pull request Jan 8, 2025
CHORE: Update python requirement to <3.14 #15
Closed
@RobPasMue RobPasMue self-assigned this Jan 8, 2025
@RobPasMue
RobPasMue marked this pull request as ready for review January 8, 2025 09:23
@RobPasMue
RobPasMue requested review from SMoraisAnsys, dipinknair and koubaa January 8, 2025 09:23
@RobPasMue

RobPasMue commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

I also submitted pythonnet/pythonnet#2542 to fix their CI/CD - the job exclusion should have been done in this way. See 3b78bf1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RobPasMue

RobPasMue commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

Once merged, a new release should be done. This will open the door to projects depending on this fork
SMoraisAnsys reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SMoraisAnsys
SMoraisAnsys approved these changes Jan 8, 2025
View reviewed changes

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RobPasMue
RobPasMue merged commit 0ba6a76 into main Jan 8, 2025
@RobPasMue
RobPasMue deleted the feat/update-fork branch January 8, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes
@koubaa koubaa Awaiting requested review from koubaa
@dipinknair dipinknair Awaiting requested review from dipinknair

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@RobPasMue RobPasMue

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RobPasMue @SMoraisAnsys @filmor @koubaa @jorgepiloto
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.