GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out by sureshanaparti · Pull Request #2092 · apache/cloudstack Conversation
|
| throw new RuntimeException("vCenter task failed due to " + we.getLocalizedMessage()); | ||
|
|
||
| // Since task cancellation is asynchronous, wait for the task to be cancelled | ||
| Object[] result = waitForValues(task, new String[] {"info.state", "info.error"}, new String[] {"state"}, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Should there be a check for length of result to avoid array-bound exceptions when accessing result[0], result[1] etc.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@rhtyd The properties list to filter in the above waitForValues() are "info.state" and "info.error". The result size returned from waitForValues() would be same as the properties list size, which is 2 and so the result Object array would hold two objects: result[0], result[1].
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@sureshanaparti I see that however my comment aimed to encourage defensive programming. Maybe now the code works, but it can still improve upon overall elegance and include additional checks to defend future bugs [1].
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@rhtyd ok. will check and update. Thanks for the review.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@rhtyd Updated the code. Please take a look. Thanks.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@blueorangutan package |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-728 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@blueorangutan test centos7 vmware-55u3 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Trillian test result (tid-1101)
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Above test failures are not related to this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 Failed tests:
Skipped tests: Passed test suits: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… when vCenter session timed out
|
@blueorangutan package |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-965 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@blueorangutan test centos7 vmware-55u3 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Trillian test result (tid-1389)
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@blueorangutan package |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1061 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@blueorangutan test centos7 vmware-55u3 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Trillian test result (tid-1472)
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
LGTM, test failures not related to this PR. Additional review requested @niteshsarda @nitin-maharana @karuturi @sureshanaparti and others |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
code LGTM, IMHO hard to have a test case for it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merging this based on 2 LGTMs and test results confirmation from @rhtyd and @resmo. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.