GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: make version more maintainable and change it to 0.1.0 by archerny · Pull Request #35 · apache/horaedb-client-java

This repository was archived by the owner on Mar 12, 2026. It is now read-only.

Conversation

@archerny

@archerny archerny commented Jan 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

No, it is just the chore before release.

Rationale for this change

The version field is scattered everywhere in the repo. The parent pom.xml and its children have their own version, however, in almost every case, they should be identical. Modifying all fields is tedious and error-prone work.

What changes are included in this PR?

  • We should use one variable to maintain versions. According to a document from Apache Maven, this is easy.
  • Reference: https://maven.apache.org/maven-ci-friendly.html

Are there any user-facing changes?

Real users are not influenced. Developers of this project should take care of this PR. If you want to change the version field, just modify the property revision in parent pom, rather than modify all pom files. It was not convenient to maintain the version field before. Developers would forget to alter the version field in child pom.

How does this change test

Pass the existing CI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
archerny added 3 commits January 11, 2023 01:48
@archerny
chore: make version more maintainable and change it to 0.1.0
cba4dc5
@archerny
feat: add flatten-maven-plugin
a609808
@archerny
chore: refine gitignore
7cf0d34
@archerny
archerny requested a review from ZuLiangWang January 11, 2023 04:08
ZuLiangWang
ZuLiangWang approved these changes Jan 11, 2023
View reviewed changes

@ZuLiangWang ZuLiangWang left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ZuLiangWang
ZuLiangWang merged commit 6505fec into apache:main Jan 11, 2023
@archerny archerny mentioned this pull request Jan 12, 2023
refactor: auto retrieve version from pom #37
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ZuLiangWang ZuLiangWang ZuLiangWang approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@archerny @ZuLiangWang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.