GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(router): allow internal jobs endpoint and callbacks over HTTP when force-HTTPS is enabled by hardikkaurani · Pull Request #15500 · appwrite/appwrite

Conversation

@hardikkaurani

@hardikkaurani hardikkaurani commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

With _APP_OPTIONS_FORCE_HTTPS=enabled, internal HTTP calls from the orchestrator to /v1/jobs/event or targets under _APP_JOBS_ENDPOINT were rejected with HTTP 500 because general.php only allowed localhost and _APP_MIGRATION_HOST. Added Platform::getLocalHosts() and Platform::isForceHttpsExempt() so _APP_JOBS_ENDPOINT hosts and /v1/jobs/event callbacks bypass the HTTPS check. Covered with unit tests in ForceHttpsTest and checked with Pint.

Fixes #15047

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hardikkaurani
fix(router): allow internal jobs endpoint and callbacks over HTTP whe…
309899b 
…n force-HTTPS is enabled
Copilot AI balanced review requested due to automatic review settings November 11, 2026 18:44
Copilot AI reviewed Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@appwrite

appwrite Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The force-HTTPS guard now allows configured internal jobs and migration hosts over HTTP and exempts the jobs-event callback path. The exemption and host-resolution logic live in Appwrite\Network\Platform, which the router calls directly, with unit tests covering the production helper behavior.

Latest changes: The new commits moved host resolution and force-HTTPS exemption decisions into Platform and updated the unit tests to call those production methods directly.

Verdict New comments Fixed Still open
💬 Commented 0 1 0

Note

@hardikkaurani does not have write access to this repository, so Hansi does not approve automatically. A maintainer can review and approve.

📂 Walkthrough · 3
File Change
app/controllers/general.php Uses the shared Platform helpers to resolve internal hosts and decide force-HTTPS exemptions.
src/Appwrite/Network/Platform.php Adds helpers for resolving allowed local hosts and evaluating force-HTTPS exemptions.
tests/unit/Network/ForceHttpsTest.php Tests the production helpers for default and custom jobs hosts, migration hosts, callback exemption, and regular HTTP requests.
✅ Fixed since the last review · 1
  • Exercise the production force-HTTPS decision · tests/unit/Network/ForceHttpsTest.php:50

Reviewed the commits since 309899b · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@appwrite appwrite deleted a comment from hardikkaurani Nov 11, 2026
appwrite[bot]
appwrite Bot reviewed Nov 11, 2026
View reviewed changes

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/unit/Network/ForceHttpsTest.php Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hardikkaurani
refactor(network): move force-HTTPS helper to Platform and exercise d…
da09d3c 
…irectly in tests
@hardikkaurani

hardikkaurani commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@appwrite review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
appwrite[bot]
appwrite Bot reviewed Nov 11, 2026
View reviewed changes

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hardikkaurani

hardikkaurani commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Moved the host allowlist and exemption logic onto Platform so ForceHttpsTest exercises the production methods directly instead of duplicating the condition. Pint and unit tests pass locally. Ready for a look @eldadfux @HarshMN2345 @ChiragAgg5k.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appwrite appwrite[bot] appwrite[bot] left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Site/function deployments stuck in “waiting” on 2.6.2: orchestrator callback to /v1/jobs/event rejected when _APP_OPTIONS_FORCE_HTTPS=enabled

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hardikkaurani
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.