GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — unified: do not call a null symbol in af_get_last_error by melonakos · Pull Request #3718 · arrayfire/arrayfire

Conversation

@melonakos

@melonakos melonakos commented Sep 10, 2026

Copy link
Copy Markdown
Member

When no backend is loaded, LOAD_SYMBOL() returns null and af_get_last_error called through it. The function returns void so it cannot report AF_ERR_LOAD_LIB; return an empty error instead. Fixes #3713.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@melonakos @claude
Guard against unresolved symbol in unified af_get_last_error
cda1c99
LOAD_SYMBOL() returns null when no backend library is loaded or the
symbol cannot be resolved. af_get_last_error called the resulting
function pointer unconditionally, which is an indirect call through a
null pointer.

Every other unified entry point goes through CALL(), which null-checks
and returns AF_ERR_LOAD_LIB. af_get_last_error returns void and cannot,
so report an empty error instead.

Fixes #3713

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_012SRueobKykUocB1SRdHsEE
@melonakos
melonakos force-pushed the fix/3713-unified-null-symbol branch from 701862a to 44d14aa Compare September 10, 2026 18:47
@melonakos
unified: return an empty string, not NULL, when no backend is loaded
312bc21
Every caller passes len as NULL and formats the message with %s, so a NULL string is undefined behaviour. Allocate an empty message the way the C API does.
@melonakos
melonakos force-pushed the fix/3713-unified-null-symbol branch from 44d14aa to 312bc21 Compare September 10, 2026 18:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Unified backend: af_get_last_error calls unresolved symbol without null check

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@melonakos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.