GeezerVison is showing github.com — cpu: fix the FAST non-max bounds check by melonakos · Pull Request #3720 · arrayfire/arrayfire
Conversation
melonakos
commented
Sep 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The FAST non-max check ran after the neighbourhood reads and compared y against dims[1] and x against dims[0], so on non-square images it read out of bounds and rejected every keypoint. This is @jlaxson's commit from #3357, authorship kept. The SUSAN and Harris changes @syurkevi added on top in that PR swap the reported x/y coordinates and fail the SUSAN test suite against the current gold data, so they are left out until that convention is settled.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The check ran after the neighbourhood reads and compared y against dims[1] and x against dims[0], so on non-square images it read out of bounds and rejected every keypoint. Move it before the reads and use the right dimension for each axis. Extracted from #3357.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.