GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — api: materialise a strided view before assigning into it by melonakos · Pull Request #3729 · arrayfire/arrayfire

Conversation

melonakos commented Sep 12, 2026

Copy link

Copy Markdown

Member

Assigning an element into an array that is itself a non-linear view silently did nothing on every backend: after a = a.rows(0, 3), a(0, 0) = 1234 leaves a unchanged (#3534). The sequence-assignment path slices the output with createSubArray, which copies a non-linear parent before slicing it, so the write landed in a temporary. When the output is not linear it is now copied to a linear array first, the same thing that already happens when the output is shared. Adds a regression test covering sequence and index-array assignment into a view.

Verified on the CPU backend and on OpenCL (Intel Arc B580 and UHD 770): the new test fails on master and passes with the fix, and the assign suite passes in full on all three.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Materialise a strided view before assigning into it

ddc697e

An array that is itself a non-linear view (a = a.rows(0, 3)) lost every
element assignment: createSubArray copies a non-linear parent before slicing
it, so the write landed in a temporary. The assignment path now copies such an
output to a linear array first. Fixes #3534.

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.