GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cpu: evaluate arrays past 2^31 elements and sum with compensation by melonakos · Pull Request #3731 · arrayfire/arrayfire

Conversation

@melonakos

@melonakos melonakos commented Sep 12, 2026

Copy link
Copy Markdown
Member

Two CPU-backend halves of #3571. The JIT evaluation loop counted elements in int, so an array of more than 2^31 elements was never evaluated and every reduction over it returned 0; the linear index is now dim_t through Node::calc and the loop. Separately, the all-elements add reduction accumulated in one pass, so 1e9 float ones summed to 16777216 (2^24) and norm came out as 4096; it now carries a Kahan correction, the same thing #3687 does for the dimension-wise sum, which still plateaus at 2^24 until that PR lands.

Verified here with 1e9 and 2.2e9-element arrays (sum, count, max, norm, f32/f64/u8 all exact after the change), and the reduce and jit suites pass on CPU and on OpenCL (Intel Arc B580). Adds a 1e8-element exact-sum test; the 2^31 case is not in the suite because it needs 9 GB. The OpenCL and CUDA JIT kernels index with int too and are not touched here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@melonakos
Evaluate JIT arrays past 2^31 elements and sum with compensation on CPU
1ddd9b1
The CPU JIT evaluation loop counted elements in int, so an array of more than
2^31 elements was left unevaluated and every reduction over it returned 0;
the linear index is now dim_t through Node::calc. The all-elements add
reduction also lost the low-order bits in one pass (1e9 float ones summed to
2^24), so it now carries a Kahan correction, as #3687 does for the
dimension-wise sum. Both halves of #3571 on the CPU backend.
@melonakos melonakos mentioned this pull request Oct 24, 2026
ci: restore build checks and CPU summation accuracy #3735
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@melonakos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.