GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove rustc_serialize in favor of Serde crate by 9prady9 · Pull Request #130 · arrayfire/arrayfire-rust

Conversation

@9prady9

@9prady9 9prady9 commented Apr 27, 2017

Copy link
Copy Markdown
Member

Fixes #129

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@9prady9
Remove rustc_serialize in favor of Serde crate
d558748
@9prady9 9prady9 added the Enhancement label Apr 27, 2017
@9prady9 9prady9 added this to the 3.5.0 milestone Apr 27, 2017
@9prady9
9prady9 requested a review from jramapuram April 27, 2017 06:44
@9prady9

9prady9 commented May 8, 2017

Copy link
Copy Markdown
Member Author

@jramapuram Feedback ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jramapuram

jramapuram commented May 8, 2017

Copy link
Copy Markdown
Member

Looks good! Sorry for the delay!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jramapuram
jramapuram approved these changes May 8, 2017
View reviewed changes
@9prady9

9prady9 commented May 8, 2017

Copy link
Copy Markdown
Member Author

that's fine, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@9prady9
9prady9 merged commit d3e2d4d into arrayfire:devel May 8, 2017
@9prady9
9prady9 deleted the use_serde_for_serialization branch May 8, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jramapuram jramapuram jramapuram approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@9prady9 @jramapuram
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.