GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(security): wire Trusted Types into the framework's HTML sinks by JosunLP · Pull Request #191 · bQuery/bQuery

Conversation

@JosunLP

@JosunLP JosunLP commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #171 (Medium).

createTrustedHtml / getTrustedTypesPolicy existed but no DOM-write path called them — they were only re-exported. So under an enforced require-trusted-types-for 'script' CSP, every innerHTML =/insertAdjacentHTML in dom.ts/collection.ts/element.ts/directives threw (framework fails closed but non-functional), and the documented "Trusted Types / CSP compliance" property was simply absent.

Fix

New trustedHtmlForSink(rawHtml) in security/trusted-types.ts: returns a TrustedHTML when a policy is active (so the write satisfies enforced TT), otherwise the sanitized string — sanitizing exactly once. All sanitized sinks now route through it:

  • core/dom.ts: setHtml, createElementFromHtml, insertContent
  • core/collection.ts: Collection.html(), insertAll()
  • view/directives: bq-html (sanitized branch), bq-html-safe
  • element.ts html() inherits it via setHtml

The explicit htmlUnsafe() / sanitize: false escape hatches are deliberately left as raw writes (bypassing sanitization is their documented purpose). The sanitizeHtml JSDoc is corrected to describe actual behavior (returns a branded string; the framework's sinks wrap it for TT).

Verification

  • New test proves the positive path: with a mock TT policy installed (fresh module instance to avoid cached-policy leakage), trustedHtmlForSink invokes policy.createHTML and returns the branded TrustedHTML.
  • New test for the fallback path: returns a sanitized, sink-safe string in a non-TT environment.
  • Existing sink sanitization tests still pass (behavior unchanged without TT).
  • Full suite: 2988 pass / 0 fail. tsc --noEmit + eslint clean.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JosunLP @claude
fix(security): wire Trusted Types into the framework's HTML sinks
635e7b9
createTrustedHtml/getTrustedTypesPolicy existed but no DOM-write path
called them, so under an enforced require-trusted-types-for 'script' CSP
every innerHTML/insertAdjacentHTML assignment threw (framework broken),
and the documented 'Trusted Types / CSP compliance' property was absent.

Added trustedHtmlForSink(rawHtml): returns a TrustedHTML when a policy is
active, otherwise the sanitized string, sanitizing exactly once. Routed
all sanitized sinks through it — setHtml/createElementFromHtml/
insertContent (core/dom), Collection.html/insertAll (core/collection),
bq-html (sanitized branch) and bq-html-safe (view directives). The
explicit htmlUnsafe / sanitize:false escape hatches are left as raw
writes. Corrected the sanitizeHtml JSDoc to describe the actual behavior.

Fixes #171

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 079033c6-44e9-4dc4-a0e9-9d063b228e50

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/171-trusted-types-sinks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added core Changes to the core module security Changes to the security module view Changes to the view module tests Chenges to the tests labels Jul 6, 2026
@JosunLP
JosunLP merged commit f8d5c63 into dev Jul 6, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@JosunLP
JosunLP deleted the fix/171-trusted-types-sinks branch July 6, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core Changes to the core module security Changes to the security module tests Chenges to the tests view Changes to the view module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JosunLP
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.