GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(reactive): abort superseded in-flight fetch on overlapping execute by JosunLP · Pull Request #192 · bQuery/bQuery

Conversation

@JosunLP

@JosunLP JosunLP commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #172 (Medium; correctness / resource exhaustion).

useFetch kept a single shared currentAbortController and overwrote it on every execute(). When executions overlap (a watch refresh racing a manual refresh()/execute()), the earlier in-flight fetch was never aborted — its result was discarded by the executionId guard, but the request kept consuming network/CPU, and state.abort() could only cancel the most recent controller. Rapid watch churn piled up un-cancellable requests.

Fix

execute() aborts the previous controller (currentAbortController?.abort()) before creating the new one. The superseded request is cancelled immediately. The existing finally cleanup already only nulls the controller when it's still the current one, so no cross-execution clobbering.

Verification

  • New test: two overlapping executions; the first request's AbortSignal becomes aborted, the second stays live. Fails without the fix.
  • Reactive/http/network/concurrency suites: 335 pass / 0 fail. tsc --noEmit clean.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JosunLP @claude
fix(reactive): abort superseded in-flight fetch on overlapping execute
a872add 
useFetch stored one shared currentAbortController and overwrote it on
every execute(). Overlapping executions (a watch refresh racing a manual
refresh()/execute()) left the earlier fetch running and un-cancellable —
its result was discarded by the executionId guard, but the request kept
consuming network/CPU, and state.abort() could only cancel the latest.
Rapid watch churn piled up in-flight requests.

execute() now aborts the previous controller before starting a new
attempt, so a superseded request is cancelled immediately.

Fixes #172

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e8df035-9703-41c3-9daa-fbde50f72770

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/172-async-abort

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added reactive Changes to the reactive module tests Chenges to the tests labels Jul 6, 2026
@JosunLP
JosunLP merged commit 3973637 into dev Jul 6, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@JosunLP
JosunLP deleted the fix/172-async-abort branch July 6, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

reactive Changes to the reactive module tests Chenges to the tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JosunLP
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.