GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(reactive/concurrency): give composables a disposal path by JosunLP · Pull Request #193 · bQuery/bQuery

Conversation

@JosunLP

@JosunLP JosunLP commented Jul 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

Fixes #173 (Medium; memory leaks).

Three composables created long-lived reactive primitives with no disposal path, leaking whenever created outside an active effectScope.

Fixes

  • deferred() — created an internal effect (and its scheduled timer/idle callback) but returned only readonly(mirror), no disposer. Now returns ReadonlySignalHandle<T> & { dispose() }; dispose() stops the effect (its cleanup cancels any pending timer) and disposes the mirror. Scope-managed behavior when inside a scope is unchanged.
  • persistedSignal() — the persistence effect auto-registered with the ambient scope, so scope.stop() silently stopped persistence while the returned signal kept living, and there was no other way to stop it. Persistence now runs in a detached scope tied to the signal's own dispose(): an ambient scope.stop() no longer affects it, and signal.dispose() stops persistence.
  • effectScope(detached?) — new optional param (mirrors Vue's effectScope(true)): when true the scope isn't auto-collected by an enclosing scope. Additive, backward-compatible.

(The third sub-point in the issue — module-scope computed() retention — is a documented must-dispose contract; computed already exposes dispose(). This PR addresses the two composables that had no disposal path at all.)

Verification

  • deferred: new test asserts source changes stop flowing after dispose().
  • persistedSignal: new tests assert persistence survives an ambient scope.stop() and stops after signal.dispose(). Both new persist tests + the deferred test fail on the pre-fix code.
  • Full suite: 2989 pass / 0 fail. tsc --noEmit + eslint clean.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JosunLP @claude
fix(reactive/concurrency): give composables a disposal path
eb3cad8
Three composables created long-lived reactive primitives that leaked when
not created inside an active effectScope:

- deferred() created an internal effect (plus its scheduled timer) and
  returned only readonly(mirror), with no disposer. It now returns a
  handle with a dispose() that stops the effect (cancelling any pending
  timer) and disposes the mirror.
- persistedSignal() ran its persistence effect in the ambient scope, so
  scope.stop() silently stopped persistence while the signal kept living,
  and there was no way to stop it otherwise. Persistence now runs in a
  detached scope tied to the signal's own dispose(): stopping an ambient
  scope no longer affects it, and disposing the signal stops persistence.
- effectScope() gained an optional  parameter (Vue-style) so a
  scope's lifetime can be made independent of any enclosing scope.

Fixes #173

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9250471-23e8-41a0-a82a-189b2d9ba5ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/173-composable-disposal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added reactive Changes to the reactive module tests Chenges to the tests concurrency labels Jul 6, 2026
@JosunLP
JosunLP merged commit 213bfea into dev Jul 6, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@JosunLP
JosunLP deleted the fix/173-composable-disposal branch July 6, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

concurrency reactive Changes to the reactive module tests Chenges to the tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JosunLP
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.