GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(i18n): use own-property checks for placeholder and key resolution by JosunLP · Pull Request #194 · bQuery/bQuery

Conversation

@JosunLP

@JosunLP JosunLP commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #174 (Low; contract violation + minor info-shape leak).

interpolate and the ICU arg/select/plural sites used the in operator (and resolveKey walked key segments without a guard), which resolves inherited Object.prototype members. A placeholder or key matching toString/valueOf/constructor/__proto__/… was treated as present even when params/messages didn't own it, substituting the inherited value (e.g. Hello {toString} → the native function source) instead of leaving the literal {name} intact.

Fix

All lookup sites use Object.prototype.hasOwnProperty.call(...):

  • translate.ts: interpolate placeholder check + defensive guard in resolveKey
  • icu.ts: shared hasParam() helper used by the arg, select, and plural cases

Verification

  • New tests: {toString}/{constructor} placeholders left intact; real params still substitute; resolveKey returns undefined for inherited names; ICU arg/select unaffected by inherited names. All three fail on the pre-fix code.
  • i18n suites: 110 pass / 0 fail. tsc --noEmit clean.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JosunLP @claude
fix(i18n): use own-property checks for placeholder and key resolution
962546e 
interpolate/ICU arg+select+plural used the 'in' operator (and resolveKey
traversed segments without a guard), so a placeholder or key colliding
with an Object.prototype member (toString, constructor, __proto__, …) was
treated as present and substituted with the inherited value instead of
being left as the literal {name} — a contract violation with a minor
native-function-source info leak.

All lookup sites now use Object.prototype.hasOwnProperty.call.

Fixes #174

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18257f5b-e04b-4eaa-a2bf-30f8b542e0b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/174-i18n-proto-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added tests Chenges to the tests i18n Changes to the i18n module labels Jul 6, 2026
@JosunLP
JosunLP merged commit bd0cf9e into dev Jul 6, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@JosunLP
JosunLP deleted the fix/174-i18n-proto-guard branch July 6, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

i18n Changes to the i18n module tests Chenges to the tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JosunLP
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.