GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Reuse field inversions in Shamir recovery and division by carstenartur · Pull Request #2558 · bcgit/bc-java Conversation
Contributor
Reduce repeated field inversions in ShamirSplitSecret.getSecret() and divide(), preserving the existing API.
Verification at upstream e40316b:
The full Gradle/core suite, Checkstyle and JMH were not run for this submission. Counts above refer to field inversions, not a measured runtime speedup. Identified by the Sandbox mathematics cleanup: Generated source was adapted for naming, comments and formatting while preserving its guards, masks, fallback paths and per-row schedule. ChatGPT assisted with preparation, regression tests and review.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsAccumulate interpolation numerator and denominator products before inverting, and reuse an inverse within each share row during division. Keep the original paths for Polynomial subclasses and small inputs. Add scaling and overridden-division regression coverage. Identified with the Sandbox mathematics cleanup: https://github.com/carstenartur/sandbox AI-assisted preparation and review. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedNo active review issues block the change to reduce repeated finite-field inversions. No open issues 🎉 What changed in this PRThis PR reduces repeated finite-field inversions in Shamir secret recovery and share division while preserving the existing API and fallback behavior for Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |