GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simplify choice and majority functions in digest helpers by carstenartur · Pull Request #2559 · bcgit/bc-java

Conversation

@carstenartur

@carstenartur carstenartur commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Simplify twelve existing choice/majority helper return expressions in MD4, MD5, SHA-1, RIPEMD160, RIPEMD320 and SM3.

Nine choice expressions use three bitwise operations instead of four; three majority expressions use four instead of five. The identities preserve Java int behavior and add no calls, branches, guards or local variables. Callers remain unchanged. Already simplified SHA-2/LongDigest helpers are excluded.

Generated and independently checked by the Sandbox mathematics cleanup:
https://github.com/carstenartur/sandbox
Sandbox revision: d426c5cb6098f4377e45bc912469f160c38459ad.
Every selected edit has PRESERVE_JAVA, BITVECTOR_TRUTH_TABLE and guard NONE evidence, and occurs in the actual complete generated sources. The same edits were reproduced in both completed full-corpus scans.

Validation on upstream e40316b:

  • 14 existing official digest/HMAC test programs pass before and after, including known vectors, incremental updates, clone/memo restoration, encoded state, million-a and SHA1 interleave tests. Exact success output was checked, not only process exit status.
  • Java 25 compilation with --release 8 -Xlint:all -Xmaxwarns 10000 passes. Both complete compiler logs are byte-identical (176 existing warnings).
  • Only the six changed digest classes differ among 380 compiled classes per variant.
  • javap confirms one fewer bitwise operation in every changed helper.
  • git diff --check passes.

No full Gradle build or runtime benchmark is claimed. ChatGPT assisted with extraction, review and validation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@carstenartur
Simplify choice and majority functions in digest helpers
db68c4f
Reduce the bitwise operation count in twelve existing helpers across
MD4, MD5, SHA-1, RIPEMD160, RIPEMD320 and SM3. Keep callers unchanged.
The substitutions preserve int behavior and add no branches or locals.

Generated and independently checked by the Sandbox mathematics cleanup:
https://github.com/carstenartur/sandbox
Sandbox source: d426c5cb6098f4377e45bc912469f160c38459ad
AI-assisted extraction, review and validation.
Copilot AI balanced review requested due to automatic review settings November 8, 2026 18:36
Copilot started reviewing on behalf of carstenartur November 8, 2026 18:36
View session
Copilot AI reviewed Nov 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the digest-expression simplifications.

No open issues 🎉

What changed in this PR

This PR simplifies twelve choice and majority expressions in six core digest implementations, preserving Java int behavior while reducing each expression by one bitwise operation.

Changes:

  • Rewrites nine choice expressions using XOR-based identities.
  • Factors three majority expressions to reduce repeated operations.
  • Leaves callers, interfaces, and control flow unchanged; no runtime performance improvement is claimed.
File Description
core/​src/​main/​java/​org/​bouncycastle/​crypto/​digests/​SM3Digest.java Simplifies majority FF1 and choice GG1.
core/​src/​main/​java/​org/​bouncycastle/​crypto/​digests/​SHA1Digest.java Simplifies choice f and majority g.
core/​src/​main/​java/​org/​bouncycastle/​crypto/​digests/​RIPEMD320Digest.java Simplifies choice functions f2 and f4.
core/​src/​main/​java/​org/​bouncycastle/​crypto/​digests/​RIPEMD160Digest.java Simplifies choice functions f2 and f4.
core/​src/​main/​java/​org/​bouncycastle/​crypto/​digests/​MD5Digest.java Simplifies choice functions F and G.
core/​src/​main/​java/​org/​bouncycastle/​crypto/​digests/​MD4Digest.java Simplifies choice F and majority G.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dghgit dghgit self-assigned this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@dghgit dghgit

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@carstenartur @dghgit
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.