GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — Simplify choice and majority functions in digest helpers by carstenartur · Pull Request #2559 · bcgit/bc-java Conversation
Contributor
Simplify twelve existing choice/majority helper return expressions in MD4, MD5, SHA-1, RIPEMD160, RIPEMD320 and SM3. Nine choice expressions use three bitwise operations instead of four; three majority expressions use four instead of five. The identities preserve Java int behavior and add no calls, branches, guards or local variables. Callers remain unchanged. Already simplified SHA-2/LongDigest helpers are excluded. Generated and independently checked by the Sandbox mathematics cleanup: Validation on upstream e40316b:
No full Gradle build or runtime benchmark is claimed. ChatGPT assisted with extraction, review and validation.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsReduce the bitwise operation count in twelve existing helpers across MD4, MD5, SHA-1, RIPEMD160, RIPEMD320 and SM3. Keep callers unchanged. The substitutions preserve int behavior and add no branches or locals. Generated and independently checked by the Sandbox mathematics cleanup: https://github.com/carstenartur/sandbox Sandbox source: d426c5cb6098f4377e45bc912469f160c38459ad AI-assisted extraction, review and validation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedNo active review issues are reported for the digest-expression simplifications. No open issues 🎉 What changed in this PRThis PR simplifies twelve choice and majority expressions in six core digest implementations, preserving Java Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |