GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Validate supported bcrypt formats by OskarEichler · Pull Request #299 · bcrypt-ruby/bcrypt-ruby

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Restrict salt and stored-hash validation to the formats supported by the bundled bcrypt implementation: versions 2a, 2b, 2x, and 2y; costs 04–31; and exact salt/hash lengths. Fixes #133.

Reproduction

The current regexes accept unsupported versions such as $00$/$2z$, costs outside 04–31, and overlong salts. hash_secret then passes these values into the native layer, which returns no hash instead of raising BCrypt::Errors::InvalidSalt; Password.valid_hash? likewise reports structurally unsupported hashes as valid.

Verification

  • External baseline/fixed model covers all four supported versions, minimum/maximum costs, unsupported versions, costs 03/32/99, overlong salts, stored hashes, and the InvalidSalt boundary.
  • The complete suite passes 39 examples on Ruby 4.0.6 for both current master and a 3.1.22-based consumer.
  • All existing Openwall/Spring interoperability vectors remain green.

Limits

JRuby and non-macOS native builds were not executed locally. The accepted formats are derived from both bundled implementations and their existing vectors.

Compatibility

Proper bcrypt salts and hashes are unchanged. Inputs that the native implementation cannot process now fail Ruby validation instead of reaching the native layer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
OskarEichler added 2 commits August 29, 2026 21:37
@OskarEichler
Validate bcrypt format parameters
19d7f05
@OskarEichler
Validate stored bcrypt hashes
1175864

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hash_secret with salt version set to non-bcrypt version returns an empty string instead of raising BCrypt::Errors::InvalidSalt

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@OskarEichler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.