GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Free native crypt buffers on failure by OskarEichler · Pull Request #300 · bcrypt-ruby/bcrypt-ruby

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Free the re-entrant native output buffer before returning nil when crypt_ra fails.

Reproduction

crypt_ra allocates its output buffer before validating the bcrypt setting. When hashing fails, bc_crypt currently returns before releasing args.data. A 50,000-call native failure model raises baseline maximum RSS to about 30.3 MB; the corrected branch remains around 26.7 MB under the same command.

Verification

  • Native failure model completes 50,000 rejected calls with stable ownership.
  • The complete suite passes 39 examples on Ruby 4.0.6 after rebuilding the extension.
  • A cumulative 3.1.22 consumer also passes the suite and format-validation model.

Limits

RSS is a process-level supporting measurement, not a precise allocator trace. JRuby, Linux, Windows, and sanitizer builds were not run locally. The changed path is MRI-only and free(NULL) remains safe if allocation itself failed.

Compatibility

Successful hashing is unchanged. This only releases memory already owned by the failed native call.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@OskarEichler
Free native crypt buffers on failure
a5b65be

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@OskarEichler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.