GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use a monotonic clock for calibration by OskarEichler · Pull Request #301 · bcrypt-ruby/bcrypt-ruby

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Measure BCrypt::Engine.calibrate with Ruby's monotonic process clock instead of the adjustable wall clock.

This keeps elapsed-time measurements stable when NTP, virtualization, or an administrator moves the system clock while calibration is running, and addresses the timing fragility discussed in #235 and #248.

Reproduction

An external focused model replaces Time.now with a method that raises. The current implementation raises from calibrate; this branch returns MIN_COST for a tiny time budget because calibration no longer consults wall time.

Verification

  • bundle exec rake compile spec: 39 examples, 0 failures on Ruby 4.0.6
  • focused wall-clock-isolation model: pass

Compatibility

No public API, cost selection algorithm, or supported platform changes. Process.clock_gettime(Process::CLOCK_MONOTONIC) is available on the supported Ruby versions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@OskarEichler
Use a monotonic clock for calibration
adc14ea

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@OskarEichler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.