GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reject unsupported salt costs by OskarEichler · Pull Request #302 · bcrypt-ruby/bcrypt-ruby

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Raise BCrypt::Errors::InvalidCost when BCrypt::Engine.generate_salt receives a cost above MAX_COST.

On MRI, unsupported costs currently reach the native salt generator and return nil; JRuby raises from its Java implementation. Validating the documented upper bound in the shared Ruby layer gives both engines a deliberate bcrypt error and prevents a nil salt from escaping the public method. This is the same boundary originally reported in #27.

Reproduction

On bcrypt 3.1.22, BCrypt::Engine.generate_salt(32) returns nil on MRI. An external model checks costs 32, 99, and 2**30; all now raise BCrypt::Errors::InvalidCost, while the existing sub-minimum clamp and Password.create upper-bound behavior remain unchanged.

Verification

  • bundle exec rake compile spec: 39 examples, 0 failures on Ruby 4.0.6
  • focused upper-bound model: pass

Compatibility

Valid costs are unchanged. The only behavior change is replacing an unusable nil result or engine-specific native exception for costs above 31 with the gem's documented invalid-cost error.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@OskarEichler
Reject unsupported salt costs
4dc605b

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@OskarEichler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.