GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix source build with MSVC (x64-mswin64) by hsbt · Pull Request #303 · bcrypt-ruby/bcrypt-ruby

Conversation

hsbt commented Sep 11, 2026

Copy link

Copy Markdown

gem install bcrypt --platform ruby fails on x64-mswin64 Ruby because extconf.rb unconditionally lists x86.o in $objs. The generated Makefile has no rule to build x86.S with cl.exe, so linking aborts with LNK1181: cannot open input file 'x86.obj'. The assembly in x86.S is only used on i386 (BF_ASM == 1 in crypt_blowfish.c) and assembles to an empty object everywhere else, so this change skips it on mswin and links the portable C implementation instead. mingw and other platforms keep the current object list.

Verified with Ruby 4.0 (x64-mswin64_140) and Visual Studio 2022 Build Tools: rake compile spec passes (39 examples, 0 failures) and installing the locally built gem succeeds end to end.

Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix source build on Windows MSVC (x64-mswin64)

04f5749

extconf.rb unconditionally listed x86.o, but MSVC has no rule to
build x86.S, so linking failed with LNK1181 (cannot open x86.obj).
The assembly is only used on i386 (BF_ASM == 1) and assembles to an
empty object everywhere else, so skip it on mswin and use the
portable C implementation in crypt_blowfish.c instead.

Co-Authored-By: Claude Fable 5 <[email protected]>

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.