GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Int64 unpack fixes by loughmiller · Pull Request #4 · binaryjs/node-binarypack

Conversation

@loughmiller

@loughmiller loughmiller commented Sep 9, 2013

Copy link
Copy Markdown

Added unit tests to reproduce the issues, as well as fixes. The unit tests will not pass without a simple fix to BufferCursor that I also submitted. The unit tests for integers could probably be improved, but this is a reasonable start.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Scott Loughmiller added 4 commits September 9, 2013 13:09
Scott Loughmiller
add unit tests to reproduce int64 bugs
13c93b6
Scott Loughmiller
readUInt64 - refence buffer array inside object returned from slice
5a369c9
Scott Loughmiller
readInt64 should call readUInt64, not itself recursively
8ca8fe7
Scott Loughmiller
use patched buffercursor
03ccc02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@loughmiller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.