GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 修复无法切换到初始公众号配置的问题并完善了removeConfigStorage by rain7fine11 · Pull Request #1600 · binarywang/WxJava

Conversation

@rain7fine11

@rain7fine11 rain7fine11 commented Jun 2, 2020

Copy link
Copy Markdown

简要描述

  • 使用springboot配置的单公众号工程,mpId=111,通过addConfigStorage添加新配置mpId=222,然后switchoverTo(222)转换到新配置,再切换回来switchoverTo(111)抛异常。
  • 调用removeConfigStorage删除配置时,如果删除了唯一配置或默认配置将导致异常。

模块版本情况

  • WxJava 模块名: weixin-java-mp
  • WxJava 版本号:3.8.0

详细描述

  • 调用setWxMpConfigStorage方法进行初始化配置时,尚无默认配置存于WxMpConfigStorageHolder中,所以get方法取到的只是默认值“default”而不是传入的mpId,再经过setMultiConfigStorages把“default”配置回WxMpConfigStorageHolder,导致出错。
public void setWxMpConfigStorage(WxMpConfigStorage wxConfigProvider) {
    final String defaultMpId = WxMpConfigStorageHolder.get();
    this.setMultiConfigStorages(ImmutableMap.of(defaultMpId, wxConfigProvider), defaultMpId);
  }
  • 针对第二个问题添加了判断,根据情况打出warn日志。

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
rain7fine11 added 2 commits June 3, 2020 02:32
@rain7fine11
修复无法切换到初始公众号配置的问题
9ccf6ec
@rain7fine11
完善removeConfigStorage
9b4cde1
@binarywang
binarywang merged commit b52e676 into binarywang:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rain7fine11 @binarywang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.