GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Develop外部联系人客户详情新增增加字段 by huangxm129 · Pull Request #1690 · binarywang/WxJava

Conversation

@huangxm129

@huangxm129 huangxm129 commented Jul 29, 2020

Copy link
Copy Markdown

增加字段：remark_corp_name，addWay，oper_userid

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
huangxm129 added 2 commits July 29, 2020 17:27
@huangxm129
外部联系人客户详情新增增加字段
2b27c03 
增加字段：remark_corp_name，addWay，oper_userid

Signed-off-by: huangxiaoming <[email protected]>
@huangxm129
修改测试类
755c743 
Signed-off-by: huangxiaoming <[email protected]>
binarywang
binarywang reviewed Jul 29, 2020
View reviewed changes
Comment thread ...-java-cp/src/test/java/me/chanjar/weixin/cp/api/impl/WxCpExternalContactServiceImplTest.java Outdated
public void testGetExternalContact() throws WxErrorException {
String externalUserId = this.configStorage.getExternalUserId();
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getExternalContact(externalUserId);
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getContactDetail(externalUserId);

@binarywang binarywang Jul 29, 2020

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为啥要改呢

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huangxm129 huangxm129 Jul 29, 2020

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看到getExternalContact方法已被废弃了，换了个新的方法测试了下

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@binarywang binarywang Jul 30, 2020

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那你不应该改这个方法吧，不是已经有了testGetContactDetail方法吗？

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huangxm129 huangxm129 Jul 31, 2020

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
binarywang
binarywang reviewed Jul 30, 2020
View reviewed changes
Comment thread ...-java-cp/src/test/java/me/chanjar/weixin/cp/api/impl/WxCpExternalContactServiceImplTest.java Outdated
public void testGetExternalContact() throws WxErrorException {
String externalUserId = this.configStorage.getExternalUserId();
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getExternalContact(externalUserId);
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getContactDetail(externalUserId);

@binarywang binarywang Jul 30, 2020

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那你不应该改这个方法吧，不是已经有了testGetContactDetail方法吗？

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread weixin-java-cp/src/main/java/me/chanjar/weixin/cp/bean/WxCpUserExternalContactInfo.java Outdated
private Tag[] tags;
@SerializedName("remark_corp_name")
private String remarkCorpName;
@SerializedName("addWay")

@binarywang binarywang Jul 30, 2020

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个字段是正确的吗？怎么不是下划线分割风格的？

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@huangxm129 huangxm129 Jul 31, 2020

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
huangxm129 added 3 commits July 30, 2020 19:40
@huangxm129
客户标签组查询列表功能修改
33e584d 
Signed-off-by: huangxiaoming <[email protected]>
@huangxm129
修改测试类
03b33a9 
Signed-off-by: huangxiaoming <[email protected]>
@huangxm129
修改 add_way字段错误
a570172 
Signed-off-by: huangxiaoming <[email protected]>
@binarywang
binarywang merged commit a776e9c into binarywang:develop Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binarywang binarywang binarywang left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@huangxm129 @binarywang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.