GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 【微信小程序】支持小程序Short Link by linlinjava · Pull Request #2306 · binarywang/WxJava

Conversation

@linlinjava

@linlinjava linlinjava commented Sep 7, 2021

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@linlinjava
【微信小程序】支持小程序Short Link
9920ffb
@binarywang

binarywang commented Sep 7, 2021

Copy link
Copy Markdown
Owner

感觉完全没必要新建一个service类来增加单独的一个接口，你完全可以在WxMaLinkService这个上面增加方法
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@linlinjava

linlinjava commented Sep 7, 2021

Copy link
Copy Markdown
Author

你可以看一下微信小程序文档，Url Scheme、Url Link和Short Link 是独立的文档，因此代码实现结构也建议独立。
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@binarywang

binarywang commented Sep 10, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Owner

你可以看一下微信小程序文档，Url Scheme、Url Link和Short Link 是独立的文档，因此代码实现结构也建议独立。

文档独立可以理解。但是这两个都是link相关的，放到以link命名的service里更符合常理
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@binarywang

binarywang commented Sep 10, 2021

Copy link
Copy Markdown
Owner

代码先合并了，后期在进行重构
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@binarywang
binarywang merged commit ea31b7b into binarywang:develop Sep 10, 2021
@binarywang binarywang added this to the 4.1.9 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.9

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@linlinjava @binarywang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.