GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(微信支付):新增微信支付银行组件模块 by zhongjun96 · Pull Request #2644 · binarywang/WxJava

Conversation

zhongjun96 commented May 12, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

文档地址: 银行组件
 #2543

@binarywang 麻烦看下这些检查的问题需要处理吗？直接请求微信接口的，需要考虑攻击吗？

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

zhongjun96 added 2 commits

May 12, 2022 17:28


          face(微信支付):新增微信支付银行组件模块

5d98e42


          add bankService

98ab54f

zhongjun96 changed the title ~~face(微信支付):新增微信支付银行组件模块~~ feat(微信支付):新增微信支付银行组件模块

May 12, 2022

sonatype-lift Bot reviewed

May 12, 2022

View reviewed changes

Comment thread

weixin-java-pay/src/main/java/com/github/binarywang/wxpay/service/impl/BankServiceImpl.java

		*
		* @author zhongjun
		**/
		@RequiredArgsConstructor

sonatype-lift Bot May 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SameNameButDifferent: The name @RequiredArgsConstructor refers to [java.lang.SuppressWarnings, com.github.binarywang.wxpay.service.WxPayService] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sonatype-lift Bot reviewed

May 12, 2022

View reviewed changes

Comment thread

...a-pay/src/main/java/com/github/binarywang/wxpay/service/impl/WxPayServiceApacheHttpImpl.java


		@Override
		public String getV3WithWechatPaySerial(String url) throws WxPayException {
		HttpGet httpGet = new HttpGet(url);

sonatype-lift Bot May 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP_PARAMETER_POLLUTION: Concatenating user-controlled input into a URL

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sonatype-lift Bot reviewed

May 12, 2022

View reviewed changes

Comment thread

...a-pay/src/main/java/com/github/binarywang/wxpay/service/impl/WxPayServiceApacheHttpImpl.java

		@@ -241,7 +241,17 @@ public String getV3(String url) throws WxPayException {
		HttpGet httpGet = new HttpGet(url);

sonatype-lift Bot May 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP_PARAMETER_POLLUTION: Concatenating user-controlled input into a URL

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sonatype-lift Bot May 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sonatype-lift Bot reviewed

May 12, 2022

View reviewed changes

Comment thread

...a-pay/src/main/java/com/github/binarywang/wxpay/service/impl/WxPayServiceApacheHttpImpl.java

		HttpGet httpGet = new HttpGet(url);
		httpGet.addHeader("Accept", "application/json");
		httpGet.addHeader("Content-Type", "application/json");
		String serialNumber = getConfig().getVerifier().getValidCertificate().getSerialNumber().toString(16).toUpperCase();

sonatype-lift Bot May 12, 2022

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NULL_DEREFERENCE: object returned by getConfig().getVerifier() could be null and is dereferenced at line 252.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

binarywang commented May 15, 2022

Copy link

Copy Markdown

Owner

如果不是你这次提交代码引入的lift问题可以忽略

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

binarywang merged commit cfb5327 into binarywang:develop

May 15, 2022

binarywang linked an issue

May 15, 2022

that may be closed by this pull request

银行组件API #2543

Closed

binarywang added this to the 4.3.3 milestone

May 15, 2022

Reviewers

sonatype-lift[bot]

sonatype-lift[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

银行组件API

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

zhongjun96 commented May 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonatype-lift Bot May 12, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 12, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 12, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 12, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot May 12, 2022

Choose a reason for hiding this comment

Uh oh!

binarywang commented May 15, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zhongjun96 commented May 12, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.