GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 【微信OCR】WxOcrIdCardResult 补全字段: addr、gender、nationality by luomin0601 · Pull Request #2745 · binarywang/WxJava

Conversation

@luomin0601

@luomin0601 luomin0601 commented Jul 13, 2022

Copy link
Copy Markdown

WxOcrIdCardResult add field:

addr、gender、nationality

原测试用例:

cn.binarywang.wx.miniapp.api.impl.WxMaOcrServiceImplTest#testIdCard

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@luomin0601
WxOcrIdCardResult 补全字段: addr、gender、nationality
b314f73
sonatype-lift[bot]
sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
sonatype-lift[bot]
sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
sonatype-lift[bot]
sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
sonatype-lift[bot]
sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
sonatype-lift[bot]
sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
sonatype-lift[bot]
sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java
@SerializedName("id")
private String id;
@SerializedName("addr")
private String addr;

@sonatype-lift sonatype-lift Bot Jul 13, 2022

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SameNameButDifferent: The name addr; refers to [java.lang.SuppressWarnings, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@binarywang binarywang added this to the 4.3.8 milestone Jul 14, 2022
@binarywang
binarywang merged commit 6cbfe0a into binarywang:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments
+1 more reviewer
@ourines ourines ourines left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.3.8

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@luomin0601 @ourines @binarywang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.