GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CIF parsing: entity type should be case insensitive by josemduarte · Pull Request #1109 · biojava/biojava

Conversation

@josemduarte

@josemduarte josemduarte commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Some PDB-IHM files use upper case, unlike PDB files that use lower case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@josemduarte
Make entity type case insensitive. Also improved docs
501a09e
@josemduarte
josemduarte requested a review from sbittrich March 18, 2025 04:51
sbittrich
sbittrich approved these changes Mar 18, 2025
View reviewed changes

@sbittrich sbittrich left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I would go with equalsIgnoreCase directly. Is the change in visiblity for the constructor intended?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread biojava-structure/src/main/java/org/biojava/nbio/structure/EntityType.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@josemduarte @sbittrich
Update biojava-structure/src/main/java/org/biojava/nbio/structure/Ent…
aa0d576 
…ityType.java

Co-authored-by: Sebastian Bittrich <[email protected]>
@josemduarte

josemduarte commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

Is the change in visiblity for the constructor intended?

Apparently it's optional in enum constructor (an IntelliJ tip)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@josemduarte
josemduarte merged commit e721179 into biojava:master Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbittrich sbittrich sbittrich approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@josemduarte @sbittrich
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.